fix(template_helpers) :: stop plus and minus from overflowing on large integers - #1412
Open
81reap wants to merge 2 commits into
Open
fix(template_helpers) :: stop plus and minus from overflowing on large integers#141281reap wants to merge 2 commits into
81reap wants to merge 2 commits into
Conversation
81reap
marked this pull request as draft
August 31, 2026 20:18
81reap
marked this pull request as ready for review
August 31, 2026 20:22
lovasoa
requested changes
Sep 1, 2026
lovasoa
left a comment
lovasoa
left a comment
Collaborator
There was a problem hiding this comment.
Ideally one pr should address one specific point. If the stated goal is to fix a bug in one particular edge case, then add a test for that particular edge case.
| ScopedJson::Context(value, vec![path.to_string()]) | ||
| } | ||
|
|
||
| mod documented_helpers { |
Collaborator
There was a problem hiding this comment.
most of these already passed before, right ?
Contributor
Author
There was a problem hiding this comment.
yep, only prod fails on integer_arithmetic_falls_back_to_floats_instead_of_overflowing which also handles
If the stated goal is to fix a bug in one particular edge case, then add a test for that particular edge case.
…e integers Both helpers did unchecked i64 math, so large numbers paniced the renter in debug or silently overflowed in release. Now helpers fall back to floating point. Also removes unused H0 helper type.
81reap
force-pushed
the
mutation/04-template-helper-overflow
branch
from
September 1, 2026 23:49
4e4c226 to
9727a21
Compare
Contributor
Author
the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Both helpers did unchecked
i64math, so large numbers panicked the renter in debug or silently overflowed in release. Now helpers fall back to floating point.