fix(filesystem) :: return 404 when a request resolves to a directory - #1411
Merged
Conversation
81reap
marked this pull request as draft
August 31, 2026 20:18
81reap
force-pushed
the
mutation/03-directory-returns-404
branch
from
August 31, 2026 20:41
795386b to
bfa7d9f
Compare
Contributor
Author
|
CI failed for unrelated reasons, fixed in #1416 |
81reap
marked this pull request as ready for review
August 31, 2026 21:16
lovasoa
requested changes
Sep 1, 2026
When a directory name contains a dot the request is routed to the static file handler, which fails to read it and renders an error page. Reading a directory reports `IsADirectory` on unix but `PermissionDenied` on windows, so the status is decided by inspecting the path rather than by the error kind. The regression test covers both platforms: on unix it also exercises the windows branch, since `IsADirectory` is no longer special-cased.
81reap
force-pushed
the
mutation/03-directory-returns-404
branch
from
September 1, 2026 23:17
bfa7d9f to
07ddace
Compare
lovasoa
approved these changes
Sep 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a directory name has a file extension it is routed to the static file handler and fails with
IsADirectoryand shows a 500 error page. Now it resolves to404.