Repository navigation
Let the website changelog workflow fire on the tags this repo makes - #35
Merged
Merged
Conversation
changelog.yml triggered on tags matching "v*.*.*", but the release job of main.yml tags with the bare version it reads from SQLITE_JS_VERSION: the tags on this repository are 1.4.0, 1.4.1, 1.4.2, 1.4.3, none with a v. So the pattern never matched a tag push and the workflow has run exactly once in its life, by hand on 2026-07-21, which is why no release since has reached the website changelog. It now uses "*.*.*", the pattern flutter-package.yml has always had, and that one does fire on these tags. The glob also matches a tag that does carry a v, so the workflow still runs if the tagging ever changes. This only opens the changelog pull request against the website's staging branch -- create_release stays false -- so firing on the real tag duplicates nothing main.yml already does. The 1.4.3 tag is already pushed, so this takes effect from the next release. 1.4.3 itself would need the workflow_dispatch, whose input is described as a fake version for testing. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
changelog.ymltriggers on tags matching"v*.*.*", but the release job ofmain.ymltags withthe bare version it reads from
SQLITE_JS_VERSION:So the tags on this repository are
1.4.0,1.4.1,1.4.2,1.4.3— none of them with av, andthe pattern never matched a tag push.
gh run list --workflow changelog.ymlshows the workflow hasrun exactly once in its life, by hand on 2026-07-21, which is why no release since has reached the
website changelog.
It now uses
"*.*.*", the patternflutter-package.ymlhas always had, and that workflow does fireon these tags — it published the Flutter package for 1.4.3 a few minutes ago. A GitHub glob's
*also matches a tag that does carry a
v, so the new pattern is a superset of the old one and theworkflow still runs if the tagging ever changes.
I noticed this while releasing 1.4.3 (#34): the tag came out
1.4.3where I had writtenv1.4.3ina comment, which is what led me to the pattern.
What a reviewer should know
create_release: falseand only opens thechangelog pull request against the website's staging branch, so firing it on the real tag does
not touch what
main.ymlalready does with the GitHub release.1.4.3tag is already pushed, so this takes effect from the nextrelease. 1.4.3 itself would need the
workflow_dispatch, whose input is described as "The fakeversion to test", so I have not run it — worth checking against
sqlitecloud/changelog-actionbefore using it for a real version.
tags: ["*.*.*"],workflow_dispatchintact andcreate_release: falseunchanged. There is no way to test the trigger itself short of pushing a tag.
🤖 Generated with Claude Code