Skip to content

Let the website changelog workflow fire on the tags this repo makes - #35

Merged
marcobambini merged 1 commit into
mainfrom
fix-changelog-tag-pattern
Nov 16, 2026
Merged

marcobambini merged 1 commit into
mainfrom
fix-changelog-tag-pattern

Conversation

@marcobambini

Copy link
Copy Markdown
Member

changelog.yml triggers on tags matching "v*.*.*", but the release job of main.yml tags with
the bare version it reads from SQLITE_JS_VERSION:

tag_name: ${{ steps.tag.outputs.version }}

So the tags on this repository are 1.4.0, 1.4.1, 1.4.2, 1.4.3 — none of them with a v, and
the pattern never matched a tag push. gh run list --workflow changelog.yml shows the workflow has
run exactly once in its life, by hand on 2026-07-21, which is why no release since has reached the
website changelog.

It now uses "*.*.*", the pattern flutter-package.yml has always had, and that workflow does fire
on these tags — it published the Flutter package for 1.4.3 a few minutes ago. A GitHub glob's *
also matches a tag that does carry a v, so the new pattern is a superset of the old one and the
workflow still runs if the tagging ever changes.

I noticed this while releasing 1.4.3 (#34): the tag came out 1.4.3 where I had written v1.4.3 in
a comment, which is what led me to the pattern.

What a reviewer should know

  • Nothing is duplicated. This workflow passes create_release: false and only opens the
    changelog pull request against the website's staging branch, so firing it on the real tag does
    not touch what main.yml already does with the GitHub release.
  • It does not backfill. The 1.4.3 tag is already pushed, so this takes effect from the next
    release. 1.4.3 itself would need the workflow_dispatch, whose input is described as "The fake
    version to test", so I have not run it — worth checking against sqlitecloud/changelog-action
    before using it for a real version.
  • The YAML parses, with tags: ["*.*.*"], workflow_dispatch intact and create_release: false
    unchanged. There is no way to test the trigger itself short of pushing a tag.

🤖 Generated with Claude Code

changelog.yml triggered on tags matching "v*.*.*", but the release job of
main.yml tags with the bare version it reads from SQLITE_JS_VERSION: the tags
on this repository are 1.4.0, 1.4.1, 1.4.2, 1.4.3, none with a v. So the
pattern never matched a tag push and the workflow has run exactly once in its
life, by hand on 2026-07-21, which is why no release since has reached the
website changelog.

It now uses "*.*.*", the pattern flutter-package.yml has always had, and that
one does fire on these tags. The glob also matches a tag that does carry a v,
so the workflow still runs if the tagging ever changes.

This only opens the changelog pull request against the website's staging
branch -- create_release stays false -- so firing on the real tag duplicates
nothing main.yml already does.

The 1.4.3 tag is already pushed, so this takes effect from the next release.
1.4.3 itself would need the workflow_dispatch, whose input is described as a
fake version for testing.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
@marcobambini
marcobambini merged commit 96d1e8b into main Nov 16, 2026
15 checks passed
@marcobambini
marcobambini deleted the fix-changelog-tag-pattern branch November 16, 2026 09:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant