Repository navigation
test(cpu): achieve 100% test coverage for cpu.py - #50
Merged
Merged
Conversation
- Add tests for SER instruction (op_ser) in tests/test_data_transfer.py - Add tests for fast-path rebuilding missing/mismatched predecoded list in tests/test_cpu_edge_cases.py - Add tests for fast-path raising NotImplementedError on unhandled instructions in tests/test_cpu_edge_cases.py
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
Achieved 100% statement coverage for
src/tiny8/cpu.pyby covering previously missed lines and branches:TestSERintests/test_data_transfer.pyto test theSER(Set Register) instruction (op_ser), both via assembly execution and direct method call.test_run_rebuilds_predecoded_when_missing_or_mismatchedintests/test_cpu_edge_cases.pyto verify thatcpu.run()automatically rebuilds_predecodedduring fast-path execution (trace_enabled=False) when it is missing or mismatched.test_run_fast_path_not_implemented_instructionintests/test_cpu_edge_cases.pyto verifyNotImplementedErroris raised on unknown opcodes during fast-path execution.How tested
uv run pytest --cov=tiny8.cpu --cov-report=term-missing:src/tiny8/cpu.py: 548/548 statements, 100% coverage (0 missing lines).uv run ruff check tests/test_data_transfer.py tests/test_cpu_edge_cases.py: passed.uv run ruff format --check tests/test_data_transfer.py tests/test_cpu_edge_cases.py: passed.