Repository navigation
Conversation
Trino accepts underscores as digit separators, for example 1_000_000, but the Trino dialect rejected them with a parse error.
mosabua
force-pushed
the
trino-underscores-in-numbers
branch
from
October 15, 2026 06:10
7fc0fee to
dc6bec6
Compare
mosabua
marked this pull request as ready for review
October 16, 2026 03:50
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Trino accepts underscores as digit separators in numeric literals, for example
1_000_000or123_456.789_123, as described in theTrino data types documentation.
The Trino dialect did not enable
underscoresInNumbers, so formatting such aquery failed:
Changes:
underscoresInNumbersin the Trino dialect, as the DuckDB,PostgreSQL, and ClickHouse dialects already do.
Found while testing the format action of the
Trino query editor, which uses
sql-formatterwith the Trino dialect.