Skip to content

Ignore static JavaBean getter methods #37081

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
arnabnandy7 wants to merge 1 commit into
base: main
Choose a base branch
from
+23 −2
Open

Ignore static JavaBean getter methods #37081

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions spring-beans/src/main/java/org/springframework/beans/PropertyDescriptorUtils.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,7 @@
import java.beans.IntrospectionException;
import java.beans.PropertyDescriptor;
import java.lang.reflect.Method;
import java.lang.reflect.Modifier;
import java.util.ArrayList;
import java.util.Collection;
import java.util.Enumeration;
Expand Down Expand Up @@ -71,11 +72,13 @@ public static Collection<? extends PropertyDescriptor> determineBasicProperties(
setter = true;
nameIndex = 3;
}
else if (methodName.startsWith("get") && method.getParameterCount() == 0 && method.getReturnType() != void.class) {
else if (methodName.startsWith("get") && method.getParameterCount() == 0 &&
method.getReturnType() != void.class && !Modifier.isStatic(method.getModifiers())) {
setter = false;
nameIndex = 3;
}
else if (methodName.startsWith("is") && method.getParameterCount() == 0 && method.getReturnType() == boolean.class) {
else if (methodName.startsWith("is") && method.getParameterCount() == 0 &&
method.getReturnType() == boolean.class && !Modifier.isStatic(method.getModifiers())) {
setter = false;
nameIndex = 2;
}
Expand Down
18 changes: 18 additions & 0 deletions ...c/test/java/org/springframework/beans/PropertyDescriptorUtilsPropertyResolutionTests.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,6 +69,13 @@ void classWithOnlyGetter() {
assertReadAndWriteMethodsForClassAndId(pdMap, Number.class, null);
}

@Test
void classWithStaticGetters() {
var pdMap = resolver.resolve(ClassWithStaticGetters.class);

assertThat(pdMap).containsOnlyKeys("class");
}

@Test
void classWithOnlySetter() {
var pdMap = resolver.resolve(ClassWithOnlySetter.class);
Expand Down Expand Up @@ -134,6 +141,17 @@ public Number getId() {
}
}

static class ClassWithStaticGetters {

public static Long getId() {
return 42L;
}

public static boolean isActive() {
return true;
}
}

static class ClassWithOnlySetter {

public void setId(Long id) {
Expand Down