Update to NullAway 0.13.6, and add missing nullness annotation to address new warning#36850
Open
msridhar wants to merge 1 commit into
Open
Update to NullAway 0.13.6, and add missing nullness annotation to address new warning#36850msridhar wants to merge 1 commit into
msridhar wants to merge 1 commit into
Conversation
spring-projects-issues
added
the
status: waiting-for-triage
Contributor
Author
|
Sorry, with this fix the code doesn't pass the currently-released version of NullAway. Converted to draft; will mark ready when the new version of NullAway is released. |
org.springframework.web.util.UriComponents.VarArgsTemplateVariables to fix new warning. Signed-off-by: Manu Sridharan <msridhar@gmail.com>
msridhar
force-pushed
the
fix-warnings-upcoming
branch
from
31ccf45 to
d9e1f94
Compare
msridhar
changed the title
Contributor
Author
|
This PR is now up to date with the latest NullAway release (0.13.6) and could be landed. Possibly it's desirable to update the NullAway version in the Spring Nullability plugin, cut a release, and then update the plugin version here, but hopefully this PR is still useful. |
Contributor
|
Thanks @msridhar! |
sdeleuze
added
type: task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updates to NullAway 0.13.6. This version produces a new warning, which is fixed by adding a
@Nullableannotation. From the surrounding code it is clear thatvalueIteratorshould have typeIterator<@Nullable Object>.