Repository navigation
Consider adding a new location() API to HttpHeadersAssert #37489
Description
I recently refactored a test using RestTestClient that asserted the Location header for a 302 response.
Originally, the test looked like the following:
ResponseSpec spec = client.get().uri(...).exchange();
assertThat(RestTestClientResponse.from(spec))
.hasStatus(HttpStatus.FOUND)
.headers()
.hasHeaderSatisfying(HttpHeaders.LOCATION, values -> assertThat(values)
.singleElement()
.extracting(value -> UriComponentsBuilder.fromUri(URI.create(value)).build())
.returns("http", from(UriComponents::getScheme))
.returns("127.0.0.1", from(UriComponents::getHost))
.returns(8081, from(UriComponents::getPort))
.returns("value", from(UriComponents::getQueryParams).andThen(params -> params.getFirst("param")))
.returns(null, from(UriComponents::getQueryParams).andThen(params -> params.getFirst("error")))
.doesNotReturn(null, from(UriComponents::getQueryParams).andThen(params -> params.getFirst("number"))));I could improve it by using AssertJ's URI assertions:
assertThat(RestTestClientResponse.from(spec))
.hasStatus(HttpStatus.FOUND)
.headers()
.hasHeaderSatisfying(HttpHeaders.LOCATION, values -> assertThat(values)
.singleElement()
.extracting(URI::create, InstanceOfAssertFactories.URI_TYPE)
.hasScheme("http")
.hasHost("127.0.0.1")
.hasPort(8081)
.hasParameter("param", "value")
.hasParameter("number")
.hasNoParameter("error"));However, inspired by location(String) in AbstractHeaderAssertions and getLocation() in HttpHeaders, I could imagine an improvement for the first part as well:
assertThat(RestTestClientResponse.from(spec))
.hasStatus(HttpStatus.FOUND)
.headers()
.location() // new API that returns AssertJ's AbstractUriAssert
.hasScheme("http")
.hasHost("127.0.0.1")
.hasPort(8081)
.hasParameter("param", "value")
.hasParameter("number")
.hasNoParameter("error"));Would you be open to adding a new location() API to HttpHeadersAssert? I'd be happy to submit a PR.
Activity