Fix sort direction ignored in GeoSearchStoreCommandArgs.sort().#3345
Open
yeonsu00 wants to merge 1 commit intospring-projects:mainfrom
Open
Fix sort direction ignored in GeoSearchStoreCommandArgs.sort().#3345yeonsu00 wants to merge 1 commit intospring-projects:mainfrom
yeonsu00 wants to merge 1 commit intospring-projects:mainfrom
Conversation
The sort(Direction) method always assigned Direction.ASC regardless of the provided argument, causing sortDescending() to have no effect. Add test to verify that sortDescending() stores only the farthest member when combined with limit(1). Closes spring-projects#3342 Signed-off-by: yeonsu00 <yeonsu00@gmail.com> Signed-off-by: Kim yeonsu <yeonsu00@gmail.com>
a588cdc to
07bc1db
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
GeoSearchStoreCommandArgs.sort(Direction)always assignedDirection.ASCregardless of the provided argument:
This caused
sortDescending()to have no effect, and the SORT DESC flagwas never passed to the underlying Redis GEOSEARCHSTORE command in either
Lettuce or Jedis drivers.
The equivalent method in
GeoSearchCommandArgsis implemented correctly andserved as a reference.
Fix
Assign the provided direction argument directly:
Testing
Added integration test
geoSearchAndStoreShouldRespectSortDirectionthat:searchAndStorewithsortDescending().limit(1)Closes #3342