Honor runtime classpath exclusions during AOT processing - #51383
Open
gregjotau wants to merge 1 commit into
Open
Honor runtime classpath exclusions during AOT processing#51383gregjotau wants to merge 1 commit into
gregjotau wants to merge 1 commit into
Conversation
Signed-off-by: GT <gregjotau@gmail.com>
spring-projects-issues
added
the
status: waiting-for-triage
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
processAotClasspathandprocessTestAotClasspathare assembled from the parent configurations of their respective runtime classpaths so that development-only dependencies can be omitted. As a result, exclusion rules declared directly onruntimeClasspathortestRuntimeClasspathare currently lost.This can make AOT processing evaluate classpath conditions differently from the packaged application. For example, excluding
aspectjweaverfromruntimeClasspathstill exposes it to AOT processing, which selectsAnnotationAwareAspectJAutoProxyCreator; the AOT-processed application then fails at runtime because AspectJ is correctly absent.Copy the direct runtime classpath exclusion rules immediately before resolving the AOT processing classpath. Doing this lazily honors exclusions configured after the AOT plugin is applied. Integration tests cover both application and test AOT classpaths on the supported Gradle versions.
Verified with: