Preserve nested Flyway migration paths in native images#50433
Open
DragonFSKY wants to merge 1 commit into
Open
Preserve nested Flyway migration paths in native images#50433DragonFSKY wants to merge 1 commit into
DragonFSKY wants to merge 1 commit into
Conversation
spring-projects-issues
added
the
status: waiting-for-triage
Preserve the classpath-relative path for Flyway migrations discovered by the native image resource provider so nested migrations remain readable. See spring-projectsgh-50422 Signed-off-by: Dongliang Xie <dragonfsky@gmail.com>
DragonFSKY
force-pushed
the
fix/50422-flyway-native-resource-path
branch
from
2fff5b5 to
bd0c12a
Compare
Contributor
Author
|
I tried to keep the fix focused on preserving the classpath-relative resource path returned by the resolver, without changing the existing Flyway location scanning behavior. Please let me know if you would prefer a different shape for the implementation. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
NativeImageResourceProviderrecursively discovers Flyway migrations in native images, but converted each discovered resource using only its filename. This flattened nested migrations such asdb/migration/nested/V2__users.sqltodb/migration/V2__users.sql, making the returned Flyway resource unreadable.This change preserves the classpath-relative path from the resolver result, deriving it from the root/resource URIs for non-
ClassPathResourceresults. The regression test forces the native-image branch and verifies that the nested migration can be read.Closes #50422
Tests:
./gradlew :module:spring-boot-flyway:check