Migrate Notion API with latest 2025-09-03 version#203
Open
roeniss wants to merge 3 commits intospring-projects:mainfrom
Open
Migrate Notion API with latest 2025-09-03 version#203roeniss wants to merge 3 commits intospring-projects:mainfrom
roeniss wants to merge 3 commits intospring-projects:mainfrom
Conversation
Contributor
Author
|
I will rebase and force-push when #204 is merged |
Signed-off-by: Roeniss Moon <roeniss2@gmail.com>
Signed-off-by: Roeniss Moon <roeniss2@gmail.com>
Signed-off-by: Roeniss Moon <roeniss2@gmail.com>
Contributor
Author
|
@scordio All rebased. please approve one more time! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #198
Background
The latest Notion API, version 2025-09-03, created new concept named "Data Source". Data Source contains one or more Pages and Database became a wrapper for multiple Data Sources.
Implementation and Intention
I tried to minimize the impact on users. For that, instead of forcing users into specifying the Data Source ID, I internally query Data Source ID list using Database API (
databases/{database_id}) then use the first id in the response.For the most users, this would be intuitive and easy to use. But for advanced users who create multiple Data Sources in a single Database, such hidden discovery could be hassle. Because of this, I created another constructor which accepts
dataSourceIdfrom user and skips discovery phase.