Skip to content

Signed-off-by: Dileep Kumar Somajohassula dileepharithasa@gmail.com - Replace HashMap with ConcurrentHashMap for producer and consumer #3200

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
dileepharithasa wants to merge 1 commit into
base: main
Choose a base branch
from
+6 −5
Open

Signed-off-by: Dileep Kumar Somajohassula dileepharithasa@gmail.com - Replace HashMap with ConcurrentHashMap for producer and consumer #3200

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 6 additions & 5 deletions ...g-cloud-stream/src/main/java/org/springframework/cloud/stream/binding/BindingService.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,10 +20,11 @@
import java.util.ArrayList;
import java.util.Collection;
import java.util.Collections;
import java.util.HashMap;
import java.util.LinkedHashMap;
import java.util.List;
import java.util.Map;
import java.util.concurrent.ConcurrentHashMap;
import java.util.concurrent.CopyOnWriteArrayList;
import java.util.concurrent.locks.ReentrantLock;
import java.util.stream.Stream;

Expand Down Expand Up @@ -76,9 +77,9 @@ public class BindingService {

private final BindingServiceProperties bindingServiceProperties;

private final Map<String, Binding<?>> producerBindings = new HashMap<>();
private final Map<String, Binding<?>> producerBindings = new ConcurrentHashMap<>();

private final Map<String, List<Binding<?>>> consumerBindings = new HashMap<>();
private final Map<String, List<Binding<?>>> consumerBindings = new ConcurrentHashMap<>();

private final TaskScheduler taskScheduler;

Expand Down Expand Up @@ -170,7 +171,7 @@ public <T> Collection<Binding<T>> bindConsumer(T input, String inputName) {
}
}
bindings = Collections.unmodifiableCollection(bindings);
this.consumerBindings.put(inputName, new ArrayList<>(bindings));
this.consumerBindings.put(inputName, new CopyOnWriteArrayList<>(bindings));
return bindings;
}

Expand All @@ -194,7 +195,7 @@ public <T> Binding<T> doBindConsumer(T input, String inputName,
e.getCause() == null ? e.toString() : e.getCause().getMessage(), consumerProperties, true, this.objectMapper);
rescheduleConsumerBinding(input, inputName, binder, consumerProperties,
target, late, e);
this.consumerBindings.put(inputName, Collections.singletonList(late));
this.consumerBindings.put(inputName, new CopyOnWriteArrayList<>(Collections.singletonList(late)));
return late;
}
}
Expand Down