Merged
Conversation
Contributor
|
The test appears to be failing |
Signed-off-by: lanbinshen <lanbinshen@xiaomi.com>
ban-xiu
force-pushed
the
fix-issue-1204-4.3.x
branch
from
d0781e9 to
f14a7d0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Close #1204.
Remove @ConditionalOnBean(Client.class) from FeignAcceptGzipEncodingAutoConfiguration FeignAcceptGzipEncodingAutoConfiguration requires a feign.Client bean in the main context to activate. When no explicit Client bean is registered (e.g., no load balancer on classpath), response compression is silently skipped even with compression.response.enabled=true.
FeignAcceptGzipEncodingInterceptor is a RequestInterceptor that only adds an Accept-Encoding header — it has no dependency on Client. Removing this condition makes it consistent with FeignContentGzipEncodingAutoConfiguration, which never had this restriction.
All Feign client implementations (JDK HttpURLConnection, Apache HC5, Java HttpClient) handle gzip decompression transparently, so there is no risk.