Skip to content

feat(go): abstract logging behind an interface - #587

Open
nicklasl wants to merge 5 commits into
mainfrom
nicklasl/abstract-go-logging
Open

feat(go): abstract logging behind an interface#587
nicklasl wants to merge 5 commits into
mainfrom
nicklasl/abstract-go-logging

Conversation

@nicklasl

@nicklasl nicklasl commented Sep 8, 2026

Copy link
Copy Markdown
Member

Summary

  • accept a small Logger interface instead of requiring *slog.Logger
  • thread custom logging through current resolver and multi-destination logging paths
  • use a no-op logger when none is configured
  • document the interface and keep test loggers race-safe

Attribution

This revamps and supersedes #494 by @lbcjbb. The original feature commit retains Jean-Baptiste Bronisz as its Git author.

Testing

  • go test ./confidence/... -skip '^(TestFlagResolve_WithMaterialized|TestFlagResolve_WithEncryptedState|TestFlagLogs_)'
  • go vet ./...
  • focused -race test for asynchronous provider shutdown logging

The live e2e tests require Confidence credentials and are left to CI.

lbcjbb and others added 5 commits September 8, 2026 11:55
Original PR: #494

Co-Authored-By: Codex <noreply@openai.com>
Co-Authored-By: Codex <noreply@openai.com>
Co-Authored-By: Codex <noreply@openai.com>
Co-Authored-By: Codex <noreply@openai.com>
Co-Authored-By: Codex <noreply@openai.com>
@nicklasl
nicklasl marked this pull request as ready for review September 8, 2026 11:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants