fix(java): use dedicated executor for WASM compilation#313
Closed
fix(java): use dedicated executor for WASM compilation#313
Conversation
…mon pool ThreadLocalSwapWasmResolverApi was submitting N parallel WASM compilations to ForkJoinPool.commonPool() via CompletableFuture.runAsync(). Since the common pool also has ~N threads, this saturated it and starved other async work in the JVM. Add a dedicated fixed thread pool capped at 2 threads for WASM compilation, with daemon threads named wasm-compiler-%d. The executor is shut down gracefully in close(). Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
nicklasl
approved these changes
Mar 5, 2026
Member
|
Note to self: Let's re-apply on top of compositional refactor. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ThreadLocalSwapWasmResolverApiwas submitting N parallel WASM compilations toForkJoinPool.commonPool()viaCompletableFuture.runAsync(). Since the common pool also has ~N threads, this saturated it and starved other async work in the JVM (observed in service thread dumps).This adds a dedicated fixed thread pool capped at 2 threads (
wasm-compiler-%d, daemon) and passes it to bothrunAsynccall sites ininit()andupdateStateAndFlushLogs(). The executor is shut down gracefully inclose().Test plan
mvn test -f openfeature-provider/java/pom.xml)🤖 Generated with Claude Code