fix: honor the --no-telemetry CLI flag - #67
Merged
Conversation
bespoyasov
approved these changes
Sep 9, 2026
bespoyasov
left a comment
bespoyasov
left a comment
Collaborator
There was a problem hiding this comment.
Nice, thank you! Will merge it now.
the full suite has 179 passing tests and 10 UI failures.
Thanks for flagging! We'll check and update the tests and linting on Windows
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes
--no-telemetry, which currently exits withUnknown argument: telemetryinstead of starting the wizard.Yargs treats the flag as
telemetry=false, but the CLI registers it asno-telemetry. This change aligns the option and handler so the documented flag works. The environment-variable opt-out is preserved.Added five regression tests. Three fail before the fix; all five pass afterward. Typecheck, ESLint, build, and formatting for the changed files pass.
Local validation was on Windows: the full suite has 179 passing tests and 10 UI failures. Those same 10 tests also fail on unchanged
main.pnpm qaalso stops at formattingCLAUDE.md, which is checked out as a regular file instead of its symlink on Windows. E2E tests were not run locally.