Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
35 changes: 35 additions & 0 deletions __tests__/e2e/select-goal.e2e.ts
Original file line number Diff line number Diff line change
Expand Up @@ -93,6 +93,41 @@ describe('SelectGoal screen', () => {
await session.waitForText('Toggle features to set up');
});

it('shows plain time estimate for a single goal', async () => {
using session = createSession();

await navigateToGoalSelection(session);
session.checkpoint();
await session.press('Space');
await session.press('Enter');

// OnboardProject — confirm start
await session.waitForText('Start onboarding?');
await session.press('Enter');

await session.waitForText('3–5 min.');
expect(session.snapshot()).not.toContain('per feature');
});

it('shows per-feature time estimate for multiple goals', async () => {
using session = createSession();

await navigateToGoalSelection(session);
session.checkpoint();

// Toggle Feature Flags (1st) and Event Tracking (2nd)
await session.press('Space');
await session.press('ArrowDown');
await session.press('Space');
await session.press('Enter');

// OnboardProject — confirm start
await session.waitForText('Start onboarding?');
await session.press('Enter');

await session.waitForText('3–5 min per feature');
});

it('shows goal selection for non-browser project without recording option', async () => {
using session = createSession({ project: 'statsig-node' });

Expand Down
44 changes: 44 additions & 0 deletions __tests__/ui/screens/OnboardingFlow.test.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -206,6 +206,50 @@ describe('Onboarding flow', () => {
});
});

it('shows plain time estimate for a single goal', async () => {
using project = createProjectDir();
mockNextSpawn({ hang: true });

using sut = renderScreen(<OnboardProjectScreen />, {
screen: ScreenId.OnboardProject,
dir: project.path,
goals: ['feature-flags'],
});

await waitFor(() => {
expect(sut.lastFrame()).toContain('Start onboarding?');
});

sut.stdin.write(ENTER);

await waitFor(() => {
const frame = sut.lastFrame()!;
expect(frame).toContain('3–5 min.');
expect(frame).not.toContain('per feature');
});
});

it('shows per-feature time estimate for multiple goals', async () => {
using project = createProjectDir();
mockNextSpawn({ hang: true });

using sut = renderScreen(<OnboardProjectScreen />, {
screen: ScreenId.OnboardProject,
dir: project.path,
goals: ['feature-flags', 'session-recordings'],
});

await waitFor(() => {
expect(sut.lastFrame()).toContain('Start onboarding?');
});

sut.stdin.write(ENTER);

await waitFor(() => {
expect(sut.lastFrame()).toContain('3–5 min per feature');
});
});

it('shows choose-sdk prompt for empty project', async () => {
using project = createProjectDir('empty');
mockNextSpawn({ hang: true });
Expand Down
12 changes: 11 additions & 1 deletion src/integrations/utils.ts
Original file line number Diff line number Diff line change
Expand Up @@ -10,8 +10,18 @@ export function normalizeStatusLine(line: StatusLine) {
return line.slice(STATUS_PREFIX.length);
}

const MAX_REPORT_LINE_LENGTH = 60;

export function normalizeReportLine(line: string) {
return isStatusLine(line) ? normalizeStatusLine(line) : line;
const stripped = isStatusLine(line) ? normalizeStatusLine(line) : line;
const clean = stripMarkdown(stripped);
return clean.length > MAX_REPORT_LINE_LENGTH
? clean.slice(0, MAX_REPORT_LINE_LENGTH - 1) + '…'
: clean;
}

function stripMarkdown(text: string) {
return text.replace(/\*\*(.*?)\*\*/g, '$1').replace(/`([^`]+)`/g, '$1');
}

export function spawnErrorMessage(bin: string, err: NodeJS.ErrnoException): string {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -90,6 +90,7 @@ export function OnboardProjectScreen() {
prompt={
<OnboardingBottomPrompt
phase={onboarding.phase}
goals={session.onboardingGoals}
selectSdk={onboarding.selectSdk}
onConfirmStart={handleConfirmStart}
onConfirmSkip={handleConfirmSkip}
Expand Down
Original file line number Diff line number Diff line change
@@ -1,10 +1,12 @@
import { SDK_OPTIONS } from '@lib/sdk-options.js';
import type { OnboardingGoal } from '@shared-kernel/types.js';
import { PromptPanel } from '../../../components/PromptPanel.js';
import type { OnboardingPhase } from '../useOnboardingProcess.js';
import { CONFIRM_OPTIONS, ERROR_OPTIONS } from '../actions.js';

type OnboardingBottomPromptProps = {
phase: OnboardingPhase;
goals: OnboardingGoal[];
selectSdk: (id: string, label: string) => void;
onConfirmStart: () => void;
onConfirmSkip: () => void;
Expand All @@ -15,6 +17,7 @@ type OnboardingBottomPromptProps = {

export function OnboardingBottomPrompt({
phase,
goals,
selectSdk,
onConfirmStart,
onConfirmSkip,
Expand Down Expand Up @@ -52,7 +55,13 @@ export function OnboardingBottomPrompt({
/>
);
case 'onboarding':
return <PromptPanel mode="info" status="This usually takes 3–5 min." onCancel={onCancel} />;
return (
<PromptPanel
mode="info"
status={`This usually takes 3–5 min${goals.length > 1 ? ' per feature' : ''}.`}
onCancel={onCancel}
/>
);
case 'error':
return (
<PromptPanel
Expand Down