Skip to content

fix(deps): require OpenTelemetry >=1.45.1 (SAO-20688) - #317

Open
etserend wants to merge 1 commit into
fix/sao-20688-vuln-lock-bumpsfrom
fix/sao-20688-otel
Open

etserend wants to merge 1 commit into
fix/sao-20688-vuln-lock-bumpsfrom
fix/sao-20688-otel

Conversation

@etserend

Copy link
Copy Markdown
Contributor

Stacked on #314 (base is that branch; retarget to main once #314 merges).

Summary

  • VULN-129942 (otlp-proto-http TLS verification) and VULN-130743 (opentelemetry-api tracestate ReDoS): require opentelemetry-api, -sdk and -exporter-otlp-proto-http ^1.45.1 in the root package and >=1.45.1 for api/sdk in splunk-ao-a2a.
  • Move the optional HTTP instrumentation extras from 0.59b0 to 0.66b2 (they are pinned to the OTel release line).
  • Refresh every locked OpenTelemetry package to 1.45.2 (including the entries pulled by the crewai/chromadb extras, which otherwise stayed at 1.38.0 and would still be flagged).
  • Port DiagnosticOTLPSpanExporter: OTel 1.45 removed the private OTLPSpanExporter._export and routes delivery through BaseHTTPTransport. The exporter now wraps the transport to snapshot 2xx acknowledgements, so rejection diagnostics keep working. Transport errors now come back as a failed export result instead of an exception (standard 1.45 behavior); the one affected test was updated.
  • AGENTS.md: stack line updated to OpenTelemetry 1.45.

Known limitation: splunk-ao-adk

Every google-adk 1.x release (through 1.39.1, see #316) caps opentelemetry-api/-sdk at <=1.41.1; only google-adk 2.14+ allows 1.45.x. splunk-ao-adk stays on google-adk 1.x, so installing it will resolve an earlier splunk-ao until an ADK 2.x port lands. Not addressed here.

Test plan

  • poetry install --all-extras --no-root, poetry run pytest: 2465 passed, 125 skipped (OTel 1.45.2)
  • splunk-ao-a2a: uv run pytest 68 passed, uv run mypy src/ clean
  • ruff check clean on changed files
  • splunk-ao-adk not validated against OTel 1.45 (blocked by google-adk cap above)

Raise opentelemetry-api/sdk/exporter-otlp-proto-http to ^1.45.1 and the
optional HTTP instrumentation extras to 0.66b2 in the root package, and the
api/sdk floors in splunk-ao-a2a. Refresh every locked OpenTelemetry package
to 1.45.2.

OpenTelemetry 1.45 moved OTLP HTTP delivery behind BaseHTTPTransport and
removed OTLPSpanExporter._export. DiagnosticOTLPSpanExporter now wraps the
exporter transport to capture 2xx acknowledgements for rejection detection.

Fixes VULN-129942, VULN-130743.

Co-Authored-By: Claude <noreply@anthropic.com>

@pradystar pradystar left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do we need a code change? a2a and core package otel sdk and api versions don't match. How will adk work if this is released citing the limitation in the description.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants