fix(experiment): remove deprecated job_id parameter from monitor_progress() (HYBIM-931) - #194
Open
etserend wants to merge 1 commit into
Open
fix(experiment): remove deprecated job_id parameter from monitor_progress() (HYBIM-931)#194etserend wants to merge 1 commit into
etserend wants to merge 1 commit into
Conversation
…ress() (HYBIM-931) Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
job_id: str | None = Nonekeyword argument fromExperiment.monitor_progress()signatureDeprecationWarningblockjob_iddocstring entryimport warningstest_deprecated_job_id_warnstestCHANGELOG.mdBackground
job_idwas deprecated in commitcbdfe22(HYBIM-882 / PR #109) when the jobs table was retired. Progress is now tracked directly via experiment status. This removes the parameter after the deprecation window has elapsed. Requested by @adityamehra in PR #148 review.Breaking Change
Callers passing
job_id=tomonitor_progress()must remove that argument.Out of scope
src/splunk_ao/resources/models/create_job_request.pyandcreate_job_response.py— these are auto-generated fromopenapi.yamland contain ajob_idfield for the/jobsAPI endpoint, which is unrelated to this parameter.Test plan
test_deprecated_job_id_warnsdeleted — parameter no longer existstest_experiment_progress.pyall passgrepconfirms no external callers passjob_id=tomonitor_progress()anywhere in the repoJira: HYBIM-931
🤖 Generated with Claude Code