Skip to content

Fix </fData> typo in the T1059 windows-xml.log - #1271

Open
TT5H wants to merge 1 commit into
splunk:masterfrom
TT5H:fix-t1059-windows-xml-fdata
Open

TT5H wants to merge 1 commit into
splunk:masterfrom
TT5H:fix-t1059-windows-xml-fdata

Conversation

@TT5H

@TT5H TT5H commented Nov 16, 2026

Copy link
Copy Markdown

Fixes #1270.

Line 83 of datasets/attack_techniques/T1059/excessive_distinct_processes_from_windows_temp/windows-xml.log closes the CommandLine element of a Security 4688 event with </fData>. This change replaces it with </Data>. That is the only change to the file content: </fData> becomes </Data>, so the file is one byte shorter (191,553 to 191,552 bytes) and the LFS pointer holds the new object id.

Checked:

  • All 136 lines of the new file parse as XML (Python xml.etree.ElementTree). Before, line 83 did not.
  • In Splunk Enterprise 9.3.14 with Splunk_TA_windows 9.1.2, ingested with the source XmlWinEventLog:Security that data.yml declares, all 136 events get Process_Command_Line. With the old file, 135 do.

One Security 4688 event (line 83) closed its CommandLine element with
</fData> instead of </Data>, so it was not well-formed XML. Replace it.
The file is one byte shorter.

Refs splunk#1270
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

windows-xml.log in T1059/excessive_distinct_processes_from_windows_temp has one event closed with </fData>

1 participant