Skip to content

[FME-11767] Fix impressions #265

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nmayorsplit merged 1 commit into from
Dec 15, 2025
Merged

[FME-11767] Fix impressions #265

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions synchronizer/worker/impression/single.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,6 +74,7 @@ func (i *RecorderSingle) SynchronizeImpressions(bulkSize int64) error {
Label: impression.Label,
BucketingKey: impression.BucketingKey,
Pt: impression.Pt,
Properties: impression.Properties,
}
v, ok := impressionsToPost[impression.FeatureName]
if ok {
Expand Down
8 changes: 5 additions & 3 deletions synchronizer/worker/impression/single_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,7 @@ import (
"github.com/splitio/go-split-commons/v9/storage/mocks"
"github.com/splitio/go-split-commons/v9/telemetry"
"github.com/splitio/go-toolkit/v5/logging"
"github.com/stretchr/testify/assert"
)

func TestImpressionRecorderError(t *testing.T) {
Expand Down Expand Up @@ -63,7 +64,7 @@ func TestImpressionRecorderWithoutImpressions(t *testing.T) {

func TestSynhronizeEventErrorRecorder(t *testing.T) {
impression := dtos.Impression{
BucketingKey: "someBucketingKey1", ChangeNumber: 123456789, FeatureName: "someFeature1",
BucketingKey: "someBucketingKey1", ChangeNumber: 123456789, FeatureName: "someFeature1", Properties: "{'prop':'val'}",
KeyName: "someKey1", Label: "someLabel", Time: 123456789, Treatment: "someTreatment1",
}

Expand Down Expand Up @@ -104,7 +105,7 @@ func TestImpressionRecorder(t *testing.T) {
before := time.Now().UTC()
impression1 := dtos.Impression{
BucketingKey: "someBucketingKey1", ChangeNumber: 123456789, FeatureName: "someFeature1",
KeyName: "someKey1", Label: "someLabel", Time: 123456789, Treatment: "someTreatment1",
KeyName: "someKey1", Label: "someLabel", Time: 123456789, Treatment: "someTreatment1", Properties: "{'prop':'val'}",
}
impression2 := dtos.Impression{
BucketingKey: "someBucketingKey2", ChangeNumber: 123456789, FeatureName: "someFeature2",
Expand Down Expand Up @@ -215,6 +216,7 @@ func TestImpressionRecorderSync(t *testing.T) {
if !ok || len(imp1.KeyImpressions) != 2 {
t.Error("Incorrect impressions received")
}
assert.Equal(t, "{'prop':'val'}", imp1.KeyImpressions[0].Properties)
imp2, ok := result["someFeature2"]
if !ok || len(imp2.KeyImpressions) != 1 {
t.Error("Incorrect impressions received")
Expand All @@ -227,7 +229,7 @@ func TestImpressionRecorderSync(t *testing.T) {

impression1 := dtos.Impression{
BucketingKey: "someBucketingKey1", ChangeNumber: 123456789, FeatureName: "someFeature1",
KeyName: "someKey1", Label: "someLabel", Time: 123456789, Treatment: "someTreatment1",
KeyName: "someKey1", Label: "someLabel", Time: 123456789, Treatment: "someTreatment1", Properties: "{'prop':'val'}",
}
impression2 := dtos.Impression{
BucketingKey: "someBucketingKey2", ChangeNumber: 123456789, FeatureName: "someFeature2",
Expand Down