Skip to content

BREAKING CHANGE: Update Split.Impression and renamed Split.Treatment to Split.TreatmentWithConfig #28

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
EmilianoSanchez merged 6 commits into from
Feb 14, 2025
Merged

BREAKING CHANGE: Update Split.Impression and renamed Split.Treatment to Split.TreatmentWithConfig #28

EmilianoSanchez merged 6 commits into from
Feb 14, 2025

Conversation

@EmilianoSanchez
Copy link
Contributor

@EmilianoSanchez EmilianoSanchez commented Feb 6, 2025 •
edited
Loading

  • Rename Split.Treatment struct to Split.TreatmentWithConfig and removed the label, change_number and timestamp fields.
  • Added label, change_number and timestamp fields to Split.Impression struct. Eventually, impressions might be used as the object passed to the Impression Listener.

Base automatically changed from add_flag_set_methods to development February 7, 2025 14:55
@EmilianoSanchez EmilianoSanchez marked this pull request as ready for review February 7, 2025 17:08
@EmilianoSanchez EmilianoSanchez merged commit 0d9ee59 into development Feb 14, 2025
1 check passed
@EmilianoSanchez EmilianoSanchez deleted the update_impression branch February 14, 2025 14:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sanzmauro sanzmauro sanzmauro approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@EmilianoSanchez @sanzmauro