Remove commons-validator, replace its sole usage with guava's InetAddresses.isInetAddress - #464
Open
krzysztof-tobola wants to merge 1 commit into
Open
krzysztof-tobola wants to merge 1 commit into
krzysztof-tobola wants to merge 1 commit into
Conversation
…resses.isInetAddress Signed-off-by: Krzysztof Tobola <krzysztof.tobola@gmail.com>
krzysztof-tobola
marked this pull request as ready for review
September 16, 2026 08:26
krzysztof-tobola
requested review from
maxlambrecht and
rturner3
as code owners
September 16, 2026 08:26
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a proposal to remove
commons-validatordependency and declare Guava explicitly injava-spiffe-core.This is because of unmaintained transitional dependencies that cause security scanners to raise alerts.
The commons-validator
InetAddressValidator.getInstance().isValid(..)inAddress.validateTcpAddressis replaced with Guava'sInetAddresses.isInetAddress(..).The following dependencies are removed:
No public API change. Address validation logic should remain intact, both methods check for a literal IPv4/IPv6 address without a DNS lookup, and reject hostnames, all test cases still pass.
Published POMs change: all three modules drop
commons-validator, andjava-spiffe-coregainscom.google.guava:guava:33.6.0-jreat runtime scope.