Functional components #4
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix some issues and restructure RC-files and config
…nvas as 2.6.1 is incompatible with new NPM versions
…nvas as 2.6.1 is incompatible with new NPM versions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Substantial breaking changes between this PR and the current branch. Class based react components have been rewritten as functional components, typescript has replaced javascript, and as an attempt to use composition over inheritance 5 of the previous layers (array, pipe, bluefile, websocket, wpipe) have been combined in the same layer with a specification made as to the layer type with the format property. In addition to all of that a boxes plugin has been added. Intent is to also create an accordion plugin as well.
An attempt has also been made at fleshing out the options available to the different components and building them into typescript interfaces. Likely a great deal more work is required in that domain. I included what I could relatively easily find in the sigplot code but more than likely missed a whole lot of options.