Skip to content

fix(datamodel): add missing attachment relationships#8182

Open
grantfitzsimmons wants to merge 1 commit into
v7_12_0_7_basefrom
issue-8181
Open

fix(datamodel): add missing attachment relationships#8182
grantfitzsimmons wants to merge 1 commit into
v7_12_0_7_basefrom
issue-8181

Conversation

@grantfitzsimmons

Copy link
Copy Markdown
Member

Fixes #8181

There were missing attachment data model relationships for some of the new tables. This fixes that.

Testing instructions

image

@coderabbitai

coderabbitai Bot commented Jun 10, 2026

Copy link
Copy Markdown
Contributor

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 4948292b-66e3-45f7-8ade-19e94a41a970

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch issue-8181

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@grantfitzsimmons grantfitzsimmons added this to the 7.12.0.7 milestone Jun 10, 2026

@bhumikaguptaa bhumikaguptaa left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Perform a batch edit on an attachment table and verify that you can save and commit the changes (see #8181)

I tried running a query on the Attachments table and ran into an "AttributeError" on the Absolute Age and Relative Age fields. It only happened with Attachment as a base table, and not when Collection Object was the base table.

Crash Report: Specify 7 Crash Report - 2026-06-11T15_46_07.572Z.txt

Query: New Query.json

Issue Branch:

Screen.Recording.2026-06-11.at.10.41.54.AM.1.mov

Link to DB: https://ojsmnh20260326-issue-8181.test.specifysystems.org/specify/query/334/

@github-project-automation github-project-automation Bot moved this from 📋Back Log to Dev Attention Needed in General Tester Board Jun 11, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Dev Attention Needed

Development

Successfully merging this pull request may close these issues.

Missing reverse relationships in datamodel.py for new *Attachment models

3 participants