feat: upgrade yaml library from gopkg.in/yaml.v3 to go.yaml.in/yaml/v4#163
Open
TristanSpeakEasy wants to merge 1 commit intomainfrom
Open
feat: upgrade yaml library from gopkg.in/yaml.v3 to go.yaml.in/yaml/v4#163TristanSpeakEasy wants to merge 1 commit intomainfrom
TristanSpeakEasy wants to merge 1 commit intomainfrom
Conversation
TristanSpeakEasy
added
dependencies
Contributor
📊 Test Coverage ReportCurrent Coverage: Coverage Change: ✅ No change Coverage by Package
📋 Detailed Coverage by Function (click to expand)
Generated by GitHub Actions |
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
gopkg.in/yaml.v3togo.yaml.in/yaml/v4(v4.0.0-rc.4) across 160+ filesoverlay/jsonpath.gofor jsonpath libraries that still use yaml.v3*Nodetypesyaml.TypeError→yaml.LoadErrorsin marshaller to use non-deprecated API"cannot unmarshal"→"cannot construct") and type name changes (*yaml.Node→*libyaml.Node)Notes
gopkg.in/yaml.v3remains as an indirect dependency forvmware-labs/yaml-jsonpathandspeakeasy-api/jsonpathwhich still use v3 in their APIs. These can be forked/upgraded separately.unsafe.Pointercast is safe because v4'sNodestruct is a strict superset of v3's (first 12 fields identical in type, size, and offset — verified viareflect). v4 only adds 3 new fields at the end.v4.0.0-rc.4(release candidate)Test plan
go test -count=1 ./...mise cipasses (format, lint, mod-tidy, test, integration, build)