Skip to content

chore: pin changelog-action to the version that parses commit subjects only - #205

Merged
2ynn merged 1 commit into
mainfrom
ci/bump-changelog-action
Nov 9, 2026
Merged

2ynn merged 1 commit into
mainfrom
ci/bump-changelog-action

Conversation

@2ynn

@2ynn 2ynn commented Nov 9, 2026 •

Copy link
Copy Markdown
Contributor

[skip changelog]

Why

The release for #204 failed at "Finalize release version" with The first changelog entry does not match the release source, so v2.960.7 was never tagged: https://github.com/speakeasy-api/openapi-generation/actions/runs/42701453993/job/129447302255

The "Update CHANGELOG" step runs speakeasy-api/changelog-action, pinned to 40b363f. That version passes the full commit message to @conventional-commits/parser@0.4.1. The parser reads a body line made of a single word followed by an opening parenthesis, with the closing parenthesis on a later line, as a type(scope) token, and throws. The squash commit of #204 carries a multi-line Python call in its body, so the action logged it as [INVALID] and skipped it. The other commits in the range were docs: and ci:, which are excluded types, so no changelog entry was written and the finalize script rejected the changelog.

The "Conventional Commits" step uses a different parser, accepted the same commit, and computed v2.960.7. The two steps disagreed.

What changed

Testing

Public-safety check

  • This change contains no credentials, customer documents, private repository URLs, private filesystem paths, or unredacted private logs.
  • Title, body, comments, and commit messages name no customers or customer-derived identifiers, private paths or trackers, or workflow provenance, and are understandable without private context (.claude/skills/public-repo-communication/SKILL.md).
  • Generated fixtures and review SDK changes are public-safe.
  • I reviewed git diff --check.

Summary by cubic

Pins speakeasy-api/changelog-action to a version that parses only commit subjects, fixing the release that failed to tag v2.960.7. The old version passed the full commit message to the parser, which threw on a multi-line commit body, skipped that commit as [INVALID], and left the changelog empty so the finalize step rejected it. The new version detects BREAKING CHANGE footers with a regex and produces unchanged output for commits that already parsed.

Written for commit 5a54c5b. Summary will update on new commits.

View guided diff Turn on auto-fix

@2ynn
2ynn requested a review from a team as a code owner November 9, 2026 21:27
@2ynn
2ynn requested a review from simplesagar November 9, 2026 21:27

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 1 file

Confidence score: 5/5

  • Automated review surfaced no issues in the provided summaries.
  • No files require special attention.

Shadow auto-approve: would auto-approve. Pins the release workflow's changelog-action to a fixed version that parses commit subjects only, addressing the parser failure that blocked tagging v2.960.7. This is a bounded CI tooling fix that preserves changelog output for commits that already parsed.

View guided diff | Turn on auto-fix | Re-trigger cubic

@2ynn 2ynn added the review:bypass Merge without human review approval. Required status checks still apply. label Nov 9, 2026

@speakeasybot speakeasybot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Auto-approved: review:bypass label applied by @2ynn. Required status checks still gate this merge.

@2ynn
2ynn added this pull request to the merge queue Nov 9, 2026
Merged via the queue into main with commit 8c08092 Nov 9, 2026
242 checks passed
@2ynn
2ynn deleted the ci/bump-changelog-action branch November 9, 2026 21:47
@github-actions github-actions Bot locked and limited conversation to collaborators Nov 9, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

review:bypass Merge without human review approval. Required status checks still apply.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants