Skip to content

Avoid using deprecated process.binding('http_parser')#7

Open
lamweili wants to merge 1 commit into
spdy-http2:masterfrom
lamweili:node-v12-deprecation-fix
Open

Avoid using deprecated process.binding('http_parser')#7
lamweili wants to merge 1 commit into
spdy-http2:masterfrom
lamweili:node-v12-deprecation-fix

Conversation

@lamweili

@lamweili lamweili commented Sep 18, 2021 •
edited
Loading

Copy link
Copy Markdown

@lamweili lamweili mentioned this pull request Sep 19, 2021
Open
@lamweili

lamweili commented Sep 19, 2021 •
edited
Loading

Copy link
Copy Markdown
Author

Related to a sub-issue in spdy-http2/node-spdy#380
Approving this pull request will close #6 and #7.

@lamweili lamweili changed the title Avoid using deprecated process.binding('http_parser') Closes #6 - Avoid using deprecated process.binding('http_parser') Sep 19, 2021
@lamweili lamweili changed the title Closes #6 - Avoid using deprecated process.binding('http_parser') Avoid using deprecated process.binding('http_parser') Sep 19, 2021
@jaketrimble

jaketrimble commented Oct 16, 2021

Copy link
Copy Markdown

Any movement on this PR?

@alexander-akait alexander-akait mentioned this pull request Oct 20, 2021
Closed
@alexander-akait

alexander-akait commented Oct 20, 2021

Copy link
Copy Markdown

/cc @indutny Can you review this? Will be great to fix deprecation issue

@lamweili lamweili mentioned this pull request Oct 20, 2021
Open
@tdd

tdd commented Mar 31, 2022

Copy link
Copy Markdown

Folks, it's been 6 months, and http-deceiver's dep warning here on Node >= 10 causes warnings across the board (spdy, hence restify etc.). We have a working PR, what gives? @indutny I understand you've got a full gynormous plate, but this would really help :)

@nikeee

nikeee commented Apr 18, 2022

Copy link
Copy Markdown

Any chance to get this merged? I'd be happy to help.

@Xenope

Xenope commented May 27, 2022 •
edited
Loading

Copy link
Copy Markdown

Any news? it's been a while now!

@aIbarrab

aIbarrab commented Jun 3, 2022 •
edited
Loading

Copy link
Copy Markdown

waiting for this to be merged hehe

Cc @indutny @ILOveyouo

@lamweili

lamweili commented Jun 9, 2022

Copy link
Copy Markdown
Author

cc: @jacobheun @daviddias @indutny

sternam
sternam approved these changes Nov 9, 2022
View reviewed changes

@sternam sternam left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@daviddias Looks good to me. Could you please merge it or give me write privileges I'd be happy to do it 😁

@beenotung

beenotung commented Dec 19, 2022

Copy link
Copy Markdown

I've forked this package get this PR (#7) and #5 patched and published to npm as http-deceiver-fixes

xdatravelbug
xdatravelbug approved these changes Apr 1, 2025
View reviewed changes

@xdatravelbug xdatravelbug left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested changes work as expected

@cmelius

cmelius commented May 14, 2025 •
edited
Loading

Copy link
Copy Markdown

I've forked this package get this PR (#7) and #5 patched and published to npm as http-deceiver-fixes

I tried to use

  "overrides": {
	"http-deceiver": "npm:http-deceiver-fixes@1.2.8"
 }

in my package.json (using pnpm) but spdy keeps installing the old http-deceiver. What am I doing wrong here? Any ideas?
It should replace any instances of http-deceiver with http-deceiver-fixes regardless of which package depends on it.

FIXED! It should go into the pnpm-section in a seperate override. Just in case anyone else stumbles upon this.

  "pnpm": {
    "overrides": {
      "http-deceiver": "npm:http-deceiver-fixes"
     },
  },

@khteh

khteh commented Jul 13, 2025

Copy link
Copy Markdown

When will this fix be merged?

@beenotung beenotung mentioned this pull request Jul 16, 2025
Open
@aehrfbszer aehrfbszer mentioned this pull request Jul 25, 2025
Open
@LitoMore LitoMore mentioned this pull request Aug 12, 2025
Merged
denizt added a commit to denizt/BotBuilder-Samples that referenced this pull request Aug 14, 2025
@denizt
Fix 'uncaughtException: No such module: http_parser'
bd22171 
Restify → spdy → http-deceiver chain crashes on 'npm start'
due to https://nodejs.org/api/deprecations.html#DEP0111.

Upstream fixes are not yet merged and the library cannot be bumped.
Use a patched version and override the dependency to restore
expected behavior.

See: spdy-http2/http-deceiver#7

Revert this commit once a fixed version is released and
restify dependency is upgraded.
@denizt denizt mentioned this pull request Aug 14, 2025
Closed
@RedWhiteMiko

RedWhiteMiko commented Nov 18, 2025

Copy link
Copy Markdown

When will this fix be merged?

probably never :(

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

3 more reviewers

@sternam sternam sternam approved these changes

@xdatravelbug xdatravelbug xdatravelbug approved these changes

@ILOveyouo ILOveyouo ILOveyouo approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[DEP0111] DeprecationWarning: Access to process.binding('http_parser') is deprecated.