Repository navigation
Keep runtime type errors free of ANSI escapes - #913
Open
abhinavrastogi2627 wants to merge 1 commit into
Open
abhinavrastogi2627 wants to merge 1 commit into
abhinavrastogi2627 wants to merge 1 commit into
Conversation
Fixes spdx#822 Signed-off-by: Abhinav Rastogi <abhinavrastogi9596@gmail.com>
Author
|
Ready for review when convenient. The local suite passes (1,040 tests, three skips), including terminal and non-terminal regression coverage. The GitHub test and lint workflows currently require maintainer approval. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #822.
Disable beartype's automatic terminal coloring for generated property setters. These diagnostics become strings inside
ConstructorTypeErrors, where ANSI escapes are shown literally instead of rendered. Direct property-assignment errors now use the same plain-text format. Validation and exception types are unchanged.Require beartype >=0.12.0 for the explicit color configuration. Regression tests cover constructor and setter failures with terminal detection both on and off; the two terminal cases failed before the fix.
Validation: 1,040 tests passed, 3 skipped (Python 3.12; 3 warnings). The four regression cases also pass with beartype 0.12.0 on Python 3.10. Repository-wide isort, Black and flake8 checks pass.