Spdx2to3Converter: return null for "NONE" or "NOASSERTION" Agents#380
Merged
goneall merged 1 commit intospdx:masterfrom Dec 27, 2025
Merged
Conversation
69c2423 to
f053201
Compare
goneall
approved these changes
Dec 27, 2025
Member
goneall
left a comment
There was a problem hiding this comment.
Thanks @tiegz for the PR.
I looked back through the history and it looks like the check for NONE and NOASSERTION was never implemented, so I don't expect there to be any issues with implementing the original intent based on the comments.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The javadocs for
Spdx2to3Converter.stringToAgent()say:But null is not being returned for NONE or NOASSERTION strings, so the method is creating a new "Agent" node for each time these agent values are needed, e.g. for a "suppliedBy" value:
This fix returns null instead so the convert won't create the "Agent" nodes.