-
Notifications
You must be signed in to change notification settings - Fork 93
Jessie/video watermarking #259
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
JessieeeNotLi
wants to merge
72
commits into
spcl:master
Choose a base branch
from
McLavish:jessie/video_watermarking
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
72 commits
Select commit
Hold shift + click to select a range
550cc8c
added bert as a test inference benchmark
McLavish f9c3817
hotfix to enable gpu capabilities
McLavish 0f93b66
added pre-commit hooks for linting and formatting
McLavish b965d7b
linting and formatting setting for whoever uses vscode + black + flak…
McLavish e9916db
reformatted local file so it passes linting/format
McLavish 2b75311
Merge branch 'development' into feature/bert-inference
McLavish 813af03
bert now uses gpu
McLavish 3a96f04
changed data repo to be OUR forked data repo
McLavish d4d5d30
change data loading path to own forked repo
Russellpang 1b7deb7
change data loading path to own forked repo
Russellpang 668652c
update benchmark function
Russellpang aae1023
fix: replaced onnxruntime requirement from CPU to GPU. now it actuall…
McLavish 25fd1d9
circleci mypy fix?
McLavish c478c91
Merge pull request #2 from McLavish/feature/bert-inference
McLavish d6c4227
benchmarks is now flake8/black compliant. pre-commit hooks also check…
McLavish 27b14d6
add linalg benchmarks
Russellpang ace2335
add linalg benchmarks
Russellpang ad3023d
changed CI/CD to run linting on the benchmarks folder ONLY. disabled …
McLavish 52f30c0
fix typo
Russellpang 4efff4d
update code
Russellpang f8577e7
Create .gitkeep
JessieeeNotLi dfaa14a
watermarking GPU benchmark files
JessieeeNotLi 7f4f6c9
added run benchmark script
JessieeeNotLi 1653b7c
Add usage instructions to read.me
JessieeeNotLi f5e7ab7
watermarking_readme.md
JessieeeNotLi aa3483f
Update NVENC benchmark instructions in README
JessieeeNotLi adf54a5
migrated from CircleCI to Github Actions
McLavish 67772e2
fixed workflow directory
McLavish 8f02b66
pip dependencies take too long
McLavish ae61e4b
Merge pull request #8 from McLavish/hotfix/code-quality-on-benchmarks
McLavish e06985c
new benchmark data
McLavish 037f6c3
Bring folder from other-branch
377d949
update code
8dd8a6e
modify code and requirements
fa7e76e
Create .gitkeep
JessieeeNotLi 51713f4
Add Dockerfile for NVENC-enabled FFmpeg image
JessieeeNotLi e0cfbdc
Add run script for video watermarking benchmark
JessieeeNotLi de15075
unfinished new fuc
Russellpang f534a53
Add files via upload
JessieeeNotLi 3006879
add new functions
Russellpang 7057465
Update run.sh
JessieeeNotLi 44c8bcb
Update run.sh
JessieeeNotLi e53cfde
added gpu benchmark, and test results on CPU:wq
d224ddc
add new functions
Russellpang 921f321
added recommender benchmark
McLavish dd840d1
Merge branch 'development' into feature/russell
YuxuanLiu-kayla 4fca4aa
changed data submodule to use ssh and not https
McLavish 26dfcf4
add channel_flow, compute, fft, and resnet of jax_npbench
down-street fad77da
reset the config
down-street e995e6a
Merge pull request #13 from McLavish/jiahao/npbenchs
down-street 7e0d13f
microbenchmark example
942f5a1
Remove SSH public key from eval command
Russellpang 6bc1dd7
Remove local_deployment.json configuration
Russellpang 460ea1f
Delete out_storage.json configuration file
Russellpang de41ab6
Remove SSH private key from eval command
Russellpang ded520f
remove garbage
5c85980
test
Russellpang c5782dd
test
Russellpang 2b52ced
test
Russellpang e5cb20c
Merge branch 'development' into feature/russell
Russellpang 6488d6d
remove unnecessay files
Russellpang 55c4ac4
fuck you
Russellpang b97b7a5
Refactor argument parsing for cleaner syntax
Russellpang 1998b6b
Change 'reps' to 'iters' in jacobi2d function
Russellpang 2cbd768
Delete benchmarks/000.microbenchmarks/050.matmul directory
Russellpang 074d4b7
Merge pull request #6 from McLavish/feature/russell
McLavish efced9c
Revert "changed data submodule to use ssh and not https"
McLavish bc48b5e
fix: missing config.json
McLavish e154ba0
Merge branch 'development' into feature/inference-recommender
McLavish d9ed506
Merge pull request #11 from McLavish/feature/inference-recommender
McLavish 703a05d
adapted watermarking benchmark to sebs structure
JessieeeNotLi f5093a8
Merge branch 'development' into jessie/video_watermarking
JessieeeNotLi File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file was deleted.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,55 @@ | ||
| name: Lint | ||
|
|
||
| on: | ||
| push: | ||
| pull_request: | ||
|
|
||
| jobs: | ||
| linting: | ||
| runs-on: ubuntu-latest | ||
|
|
||
| steps: | ||
| - name: Check out code | ||
| uses: actions/checkout@v4 | ||
|
|
||
| - name: Set up Python | ||
| id: setup-python | ||
| uses: actions/setup-python@v5 | ||
| with: | ||
| python-version: '3.x' | ||
|
|
||
| - name: Cache virtualenv | ||
| uses: actions/cache@v4 | ||
| with: | ||
| path: python-venv | ||
| key: venv-${{ runner.os }}-${{ steps.setup-python.outputs.python-version }}-${{ hashFiles('requirements.txt') }}-${{ github.ref_name }} | ||
| restore-keys: | | ||
| venv-${{ runner.os }}-${{ steps.setup-python.outputs.python-version }}-${{ hashFiles('requirements.txt') }}- | ||
| venv-${{ runner.os }}-${{ steps.setup-python.outputs.python-version }}- | ||
|
|
||
| - name: Install system packages | ||
| run: | | ||
| sudo apt-get update | ||
| sudo apt-get install -y libcurl4-openssl-dev | ||
|
|
||
| - name: Install Python dependencies (via install.py) | ||
| run: | | ||
| python3 install.py --no-aws --no-azure --no-gcp --no-openwhisk --no-local | ||
|
|
||
| - name: Black (check) | ||
| run: | | ||
| . python-venv/bin/activate | ||
| black benchmarks --check --config .black.toml | ||
|
|
||
| - name: Flake8 (lint) | ||
| run: | | ||
| . python-venv/bin/activate | ||
| # write to file and echo to stdout (requires flake8 with --tee support) | ||
| flake8 benchmarks --config=.flake8.cfg --tee --output-file flake-reports | ||
|
|
||
| - name: Upload flake report | ||
| if: always() | ||
| uses: actions/upload-artifact@v4 | ||
| with: | ||
| name: flake-reports | ||
| path: flake-reports | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,30 @@ | ||
| # .pre-commit-config.yaml | ||
| repos: | ||
| - repo: local | ||
| hooks: | ||
| - id: flake8-local | ||
| name: flake8 (project env) | ||
| language: python | ||
| additional_dependencies: ["flake8==7.1.1"] | ||
| entry: flake8 | ||
| args: ["--config=.flake8.cfg"] | ||
| types: [python] | ||
| files: ^(sebs/|benchmarks/) | ||
| - repo: local | ||
| hooks: | ||
| - id: black-check-local | ||
| name: black --check (project env) | ||
| language: python | ||
| additional_dependencies: ["black==22.8.0"] | ||
| entry: black | ||
| args: ["--config=.black.toml", "--check", "--diff"] | ||
| types: [python] | ||
| files: ^(sebs/|benchmarks/) | ||
| # - repo: local | ||
| # hooks: | ||
| # - id: mypy-local | ||
| # name: mypy (project venv) | ||
| # language: system | ||
| # entry: bash -lc 'python -m mypy --config-file=.mypy.ini sebs' | ||
| # types: [python] | ||
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,15 @@ | ||
| { | ||
| "[python]": { | ||
| "editor.defaultFormatter": "ms-python.black-formatter", | ||
| "editor.formatOnSave": true | ||
| }, | ||
|
|
||
| "black-formatter.importStrategy": "fromEnvironment", | ||
| "black-formatter.path": [], | ||
| "black-formatter.args": ["--config=.black.toml"], | ||
|
|
||
| "flake8.importStrategy": "fromEnvironment", | ||
| "flake8.path": [], | ||
| "flake8.args": ["--config=.flake8.cfg"], | ||
| "flake8.enabled": true | ||
| } |
Submodule benchmarks-data
updated
18 files
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,12 +1,11 @@ | ||
| size_generators = {"test": 1, "small": 100, "large": 1000} | ||
|
|
||
| size_generators = { | ||
| 'test' : 1, | ||
| 'small' : 100, | ||
| 'large': 1000 | ||
| } | ||
|
|
||
| def buckets_count(): | ||
| return (0, 0) | ||
|
|
||
| def generate_input(data_dir, size, benchmarks_bucket, input_paths, output_paths, upload_func, nosql_func): | ||
| return { 'sleep': size_generators[size] } | ||
|
|
||
| def generate_input( | ||
| data_dir, size, benchmarks_bucket, input_paths, output_paths, upload_func, nosql_func | ||
| ): | ||
| return {"sleep": size_generators[size]} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,9 +1,9 @@ | ||
|
|
||
| from time import sleep | ||
|
|
||
|
|
||
| def handler(event): | ||
|
|
||
| # start timing | ||
| sleep_time = event.get('sleep') | ||
| sleep_time = event.get("sleep") | ||
| sleep(sleep_time) | ||
| return { 'result': sleep_time } | ||
| return {"result": sleep_time} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
13 changes: 7 additions & 6 deletions
13
benchmarks/000.microbenchmarks/030.clock-synchronization/input.py
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,12 +1,13 @@ | ||
|
|
||
|
|
||
| def buckets_count(): | ||
| return 0, 1 | ||
|
|
||
| def generate_input(data_dir, size, benchmarks_bucket, input_paths, output_paths, upload_func, nosql_func): | ||
|
|
||
| def generate_input( | ||
| data_dir, size, benchmarks_bucket, input_paths, output_paths, upload_func, nosql_func | ||
| ): | ||
| return { | ||
| 'bucket': { | ||
| 'bucket': benchmarks_bucket, | ||
| 'output': output_paths[0], | ||
| "bucket": { | ||
| "bucket": benchmarks_bucket, | ||
| "output": output_paths[0], | ||
| }, | ||
| } |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Activate virtualenv before installing dependencies.
The
python3 install.pycommand runs without activating the virtualenv first. This causes dependencies to be installed in the system Python instead of the cached virtualenv, making the cache ineffective and causing subsequent steps to fail if they expect tools in the venv.Activate the virtualenv before running install.py:
- name: Install Python dependencies (via install.py) run: | + . python-venv/bin/activate python3 install.py --no-aws --no-azure --no-gcp --no-openwhisk --no-localAlternatively, use the Python binary from the venv directly:
- name: Install Python dependencies (via install.py) run: | - python3 install.py --no-aws --no-azure --no-gcp --no-openwhisk --no-local + python-venv/bin/python3 install.py --no-aws --no-azure --no-gcp --no-openwhisk --no-local📝 Committable suggestion
🤖 Prompt for AI Agents