Extract U32 texture data upload logic and restore pixelStorei parameters#367
Open
mrxz wants to merge 1 commit into
Open
Extract U32 texture data upload logic and restore pixelStorei parameters#367mrxz wants to merge 1 commit into
mrxz wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Both
SplatPagerandSparkRenderermanually uploaded texture data using theWebGLRenderingContextdirectly. This stems from a limitation in Three.js preventing 2D regions from easily being updated, see mrdoob/three.js#32254. This PR extracts the logic into a utility function to avoid duplication.Additionally the
pixelStoreiparameters set as part of this procedure weren't restored to the values they were before the upload. This becomes a problem with Three.js >= r184 as it now caches the parameter values in itsWebGLState, see #366. This PR ensures they are now properly restored. Once Spark requires Three.js 184 or later it can switch torenderer.state.pixelStoreiinstead.Fixes #366