Skip to content

Pass fileType to SplatPager when constructing SplatMesh #365

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mrxz wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Pass fileType to SplatPager when constructing SplatMesh #365

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 14 additions & 7 deletions src/SplatMesh.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ import {
SplatGenerator,
SplatTransformer,
} from "./SplatGenerator";
import { PagedSplats, SplatPager } from "./SplatPager";
import { PagedSplats, type PagedSplatsOptions, SplatPager } from "./SplatPager";
import type { SplatSkinning } from "./SplatSkinning";
import {
DEFAULT_SPLAT_ENCODING,
Expand Down Expand Up @@ -323,15 +323,22 @@ export class SplatMesh extends SplatGenerator {
);
}
const rootUrl = options.url ?? "";
if (options.paged === true) {
this.paged = new PagedSplats({ rootUrl });
} else if (options.paged instanceof PagedSplats) {
if (options.paged instanceof PagedSplats) {
this.paged = options.paged;
} else if (options.paged instanceof SplatPager) {
this.paged = new PagedSplats({ rootUrl, pager: options.paged });
} else {
throw new Error("Invalid paged option");
const pagedSplatOptions: PagedSplatsOptions = {
rootUrl,
};
if (options.paged instanceof SplatPager) {
pagedSplatOptions.pager = options.paged;
} else if (options.paged === true) {
pagedSplatOptions.fileType = options.fileType;
} else {
throw new Error("Invalid paged option");
}
this.paged = new PagedSplats(pagedSplatOptions);
}

this.splats = this.paged;
} else if (options.extSplats) {
this.extSplats =
Expand Down
Loading