feat: disable autoassign current user by default

[FabrizioCafolla]

PR Type

Enhancement

---

Description

• Changed default behavior for auto-assigning current user as maintainer

• Removed complex logic checking existing maintainer status

• Simplified project membership resource configuration

• Updated documentation to reflect new default behavior

---

Changes walkthrough 📝

	Relevant files
Enhancement	main.tf Simplify user membership logic                                                      main.tf Removed current_user_is_maintainer_of_project local variable and its complex logic Simplified gitlab_project_membership resource count condition Removed data source for checking existing project membership +1/-3
Configuration changes	variables.tf Update variable default value                                                        variables.tf Changed default value of autoassign_current_user_as_maintainer from true to false +1/-1
Documentation	CHANGELOG.md Document version 1.2.0 changes                                                      CHANGELOG.md Added new version 1.2.0 entry Documented the feature change in changelog +8/-0      README.md Update user membership documentation                                          README.md Updated documentation to reflect new default behavior Clarified that auto-assignment is now disabled by default Simplified warning about existing membership conflicts +2/-2

---

Need help?

Type /help how to ... in the comments thread for any questions about PR-Agent usage.

Check out the documentation for more information.

[Copilot]

Pull Request Overview

Changes the default behavior of automatically assigning the current GitLab user as a maintainer to newly created projects, switching from enabled by default to disabled by default.

• Default value of autoassign_current_user_as_maintainer variable changed from true to false
• Simplified membership assignment logic by removing unnecessary check for existing maintainer status
• Updated documentation to reflect the new default behavior

Reviewed Changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.

File	Description
variables.tf	Changed default value of autoassign variable from true to false
main.tf	Simplified membership assignment logic and removed maintainer check
README.md	Updated documentation to reflect new default behavior
CHANGELOG.md	Added changelog entry for version 1.2.0

---

_{Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.}

[sparkfabrik-ai-bot]

PR Reviewer Guide 🔍

Here are some key observations to aid the review process:

⏱️ Estimated effort to review: 2 🔵🔵⚪⚪⚪

🧪 No relevant tests

🔒 No security concerns identified

⚡ Recommended focus areas for review Breaking Change The removal of the complex logic checking existing maintainer status could cause Terraform to attempt creating duplicate memberships, leading to apply failures when users are already maintainers of the project. count = var.autoassign_current_user_as_maintainer ? 1 : 0 project = local.project_id user_id = data.gitlab_current_user.this.id access_level = "maintainer" } Documentation Issue The updated documentation contains a grammatical error and unclear phrasing that could confuse users about the new default behavior and when apply failures might occur. The current user used by the provider must be added as `maintainer` to the "GitLab Agents" project. This behavior by default is disable, just set the variable `var.autoassign_current_user_as_maintainer` to `true` if you want enable. Adding the user as `maintainer` to the newly created project ensures they have the permissions to commit and push to it. **ATTENTION:** If the current user is already added to the project the apply will fail saying that a membership already exists

[sparkfabrik-ai-bot]

PR Code Suggestions ✨

Explore these optional code suggestions:

Category	Suggestion	Impact
Possible issue	Prevent membership conflicts The removal of the current_user_is_maintainer_of_project check could cause resource conflicts if the user is already a project member with any access level. Consider adding a lifecycle rule to prevent destruction or handle existing memberships gracefully. main.tf [99-104] resource "gitlab_project_membership" "project" { count = var.autoassign_current_user_as_maintainer ? 1 : 0 project = local.project_id user_id = data.gitlab_current_user.this.id access_level = "maintainer" + + lifecycle { + ignore_changes = [access_level] + } } Suggestion importance[1-10]: 7 __ Why: The suggestion addresses a valid concern about potential resource conflicts when users already have project membership. However, the proposed lifecycle rule may not fully solve the issue and could mask legitimate access level changes.	Medium
General	Fix grammar errors Fix grammatical errors in the documentation. "This behavior by default is disable" should be "This behavior is disabled by default" and "if you want enable" should be "if you want to enable it". README.md [80] -The current user used by the provider must be added as `maintainer` to the "GitLab Agents" project. This behavior by default is disable, just set the variable `var.autoassign_current_user_as_maintainer` to `true` if you want enable. +The current user used by the provider must be added as `maintainer` to the "GitLab Agents" project. This behavior is disabled by default, just set the variable `var.autoassign_current_user_as_maintainer` to `true` if you want to enable it. Suggestion importance[1-10]: 4 __ Why: The suggestion correctly identifies grammatical errors in the documentation. While the fixes improve readability, they have minimal impact on functionality.	Low

[Copilot]

Pull Request Overview

Copilot reviewed 4 out of 4 changed files in this pull request and generated no new comments.

---

_{Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.}

[Copilot]

Pull Request Overview

Copilot reviewed 4 out of 4 changed files in this pull request and generated no new comments.

---

_{Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.}