Repository navigation
fix(workspace): add an entry point to reopen the local workspace - #891
Merged
xintaofei merged 5 commits intoOct 9, 2026
Merged
Conversation
This was referenced Oct 8, 2026
There was a problem hiding this comment.
🟢 Approval recommended
The implementation consistently uses the local transport, reuses established window restoration behavior, and includes focused regression coverage.
0 open findings
What changed in this PR
Adds a reliable desktop entry point for reopening the local workspace from remote-only sessions.
Changes:
- Routes local workspace opening through the local shell transport.
- Adds Quick Actions and macOS Window menu entries.
- Adds localization and regression coverage.
| File | Description |
|---|---|
src/lib/remote-workspace.ts |
Adds the local workspace API. |
src/lib/api-popup-windows.test.ts |
Verifies local transport routing. |
src/components/layout/quick-actions-dropdown.tsx |
Adds the desktop Quick Action. |
src/components/layout/quick-actions-dropdown.test.tsx |
Tests visibility and routing. |
src-tauri/src/lib.rs |
Registers the command. |
src-tauri/src/commands/windows.rs |
Shows, focuses, and remembers the local window. |
src-tauri/src/app_menu.rs |
Adds the macOS Window menu entry. |
src/i18n/messages/en.json |
Adds English messages. |
src/i18n/messages/zh-CN.json |
Adds Simplified Chinese messages. |
src/i18n/messages/zh-TW.json |
Adds Traditional Chinese messages. |
src/i18n/messages/ja.json |
Adds Japanese messages. |
src/i18n/messages/ko.json |
Adds Korean messages. |
src/i18n/messages/es.json |
Adds Spanish messages. |
src/i18n/messages/de.json |
Adds German messages. |
src/i18n/messages/fr.json |
Adds French messages. |
src/i18n/messages/pt.json |
Adds Portuguese messages. |
src/i18n/messages/ar.json |
Adds Arabic messages. |
🧠 Review effort: Balanced
Give feedback about Copilot approvals in this survey to enter a drawing for a $150 gift card.
…ends A remote window whose connection cannot be loaded, or whose credentials expired, renders a notice in place of the whole workspace, so Quick actions is not there to reach the local workspace from, and Windows has no application menu to fall back on. Without the companion recovery change, a server that stays down also lands here once the event socket gives up. Both notices now carry an "Open local workspace" button on the desktop. A failure is said under the button: the window's toaster belongs to the workspace the notice replaces.
…ndows In the local workspace the row could only focus the window it was picked from. Cover the failure toast in the tests as well.
Collaborator
|
codeg work task |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
After reopening a saved remote-only session, there was no explicit workspace action to open the local workspace. This adds an entry point that works even when the remote server is unavailable or its credentials have expired.
Validation
action_requiredwith zero jobs executed; CI validation is pending.Related work
Companion changes: Dock activation and remote restoration and recovery.