Repository navigation
Conversation
|
No issues found.
All required CI checks passed on
Select any unchecked box below to run or rerun that agent. Full resultsIndent Review Agent
|
|
No actionable comments were generated in the recent review. Walkthrough
Merge Risk:
|
Brings in the parts of #127, #125, #114, #111, #109, #105, #103, #97, #88, #87, #84 and #54 that still match shipped behavior, checked against the product source, with these corrections: - Login and permissions: the Agent access copy now quotes the access profile text, the Domain and pages-shared-with-you profiles are listed, and the login receipt is documented on stdout. - Retention: a deleted team can be restored for 30 days and keeps its records after that. Expired drafts, deleted versions and version history are kept. The Personal retained-version cap is gone. - Serving defaults: the .html redirects answer only GET and HEAD, and `index: false` stops inference instead of hiding a root index.html. - Spaces and publish: slug reservations, config file precedence, Stats columns, and when the claim message and claim.key print. - MCP: `uploadId`, `operation_status` taking `url`, the default-scope exclusions, `_meta["spacefast/requiredScopes"]`, the 24-hour approval wait, and an eval for it instead of the retired execute sandbox. - Errors: a blocked Space create or claim is `quota_exceeded`. The retired `deploy_` and `build_minutes_quota_exceeded` rows are gone. - CLI: `--team` is `-T` everywhere in the authored pages. - Undeployed hosts answer 404 with X-Spacefast-Undeployed. Functions and Zero client bundles are 24 MiB. Domain claims don't expire. #103's hand-edited generated/errors pages are left out; the next snapshot export produces them. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
What changed
Spacefast is never described with the word "hosting" (rule from batuhan, Nov 11 2026).
content/api/errors.mdx:provider_job_failedandprovider_job_timeoutrows say "provider job".content/(serve)/domains.mdx: "hosting check" is now "serving check".content/platforms/partner-api/configuration.mdx: example presentation name "Example Hosting" is now "Example Cloud".styles/Spacefast/Hosting.ymlmakes whole-word "hosting" an error. It replacesHostingProvider.yml, which only banned "the hosting provider".STYLE_GUIDE.mdandAGENTS.mddescribe the new rule.verify:prosepasses locally with Vale 3.17.1 (990 pages, 2872 OpenAPI prose fields).Kept for now (exempt from the rule)
generated/is a verified snapshot synced from spacefast/monorepo, so it is not hand-edited. Its error pages, OpenAPI descriptions and shipped changelog still contain "hosting"..vale.iniexemptscontent/(reference)/errors/**and the OpenAPI prose extraction, and the existing changelog carve-out also skips the rule, so CI stays green.Follow-ups
--hosting-kind), refreshgenerated/, then delete the two exemptions in.vale.inimarked for removal. Changelog history stays exempt.node --test scripts/*.test.mjshas 13 failures with and without this change (they need a built site); CI runs them after the build.Tag
@indentto continue the conversation here.Open in [code]smith · Need help on this PR? Tag
@codesmith-botwith what you need.Summary by CodeRabbit