Skip to content

Feat: PR 테스트 코드 추가 (#8) #9

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Feat: PR 테스트 코드 추가 (#8) #9

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,11 +1,11 @@
# velog_example
velog 에 포스팅 하는 예제 코드 입니다.
velog 에 포스팅 하는 예제 코드 가 아닙니다.

soyeon207 velog ➡️ https://velog.io/@soyeon207

|블로그 글|모듈이름|포트|
|블로그 글|모듈 이름|포트|
|---|---|---|
|[Swagger 란 ? (이론 + Spring boot 적용)](https://velog.io/@soyeon207/%EC%9A%B0%EB%8B%B9%ED%83%95%ED%83%95-Swagger-%EC%A0%81%EC%9A%A9%EA%B8%B0)|swagger-test-server|8000|
|[[실습편] 스프링 시큐리티 적용하기](https://velog.io/@soyeon207/%EC%8B%A4%EC%8A%B5%ED%8E%B8-%EC%8A%A4%ED%94%84%EB%A7%81-%EC%8B%9C%ED%81%90%EB%A6%AC%ED%8B%B0-%EC%A0%81%EC%9A%A9%ED%95%98%EA%B8%B0)|spring-security-server|8002|
|[[실습편] Spring Boot 에서 Spring Security 기반 JWT 적용하기](https://velog.io/@soyeon207/JWT-%EC%8B%A4%EC%8A%B5)|jwt-security-server|8001|
|ㅇㅇㅇ|es-test-server|8003
|ㅇㅇㅇ|es-test-server|8003|

테스트테스트
13 changes: 13 additions & 0 deletions jwt-security-server/src/main/java/velog/soyeon/jwt/controller/UsersController.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,8 +13,10 @@
import velog.soyeon.jwt.dto.UserRequest;
import velog.soyeon.jwt.service.impl.UserServiceImpl;

import java.util.ArrayList;
import java.util.Arrays;
import java.util.List;
import java.util.Set;

@RestController
@RequestMapping("/api/users")
Expand Down Expand Up @@ -49,4 +51,15 @@ public String login(UserRequest userRequest) {
return jwtConfig.createToken(users.getEmail(), Arrays.asList(users.getUserRole().getValue()));
}

@GetMapping
public List<String> test() {
List<String> userEmailList = new ArrayList<>();

List<UserDTO> userDTOList = usersService.findAll();
for (UserDTO userDTO : userDTOList) {
userEmailList.add(userDTO.getEmail());
}
return userEmailList;
Comment on lines +56 to +62
Copy link
Owner Author

@soyeon207 soyeon207 Apr 28, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

여기 stream 을 사용하면 어떨까요 ??

Suggested change
List<String> userEmailList = new ArrayList<>();
List<UserDTO> userDTOList = usersService.findAll();
for (UserDTO userDTO : userDTOList) {
userEmailList.add(userDTO.getEmail());
}
return userEmailList;
userEmailList.findAll().stream().map(UserDTO::getEmail).collect(Collectors.toList());

위처럼 더 가독성이 좋게 사용할 수 있을 것 같습니다.

}

}