Upgrade Core to 120af1f2c2992fca1d193aada8441a6717c62193

[jviotti]

Signed-off-by: Juan Cruz Viotti jv@jviotti.com

[cubic-dev-ai]

No issues found across 11 files

[augmentcode]

🤖 Augment PR Summary

Summary: Updates the vendored sourcemeta/core dependency to commit 120af1f2…, bringing in new I/O utilities and improved process-spawn error reporting.

Changes:

• Bumped the core entry in DEPENDENCIES to the new upstream SHA
• Added TemporaryDirectory (RAII temp dir creation/cleanup) and wired it into the I/O library build
• Introduced directory helpers: hardlink_directory (mirror via hard links) and atomic_directory_replace (swap/replace directories)
• Improved spawn() error classification to distinguish “program not found” from other spawn failures
• Renamed ProcessProgramNotNotFoundError to ProcessProgramNotFoundError
• Minor documentation/example fixes in jsonpointer/jsonschema/uri headers

Technical Notes: atomic_directory_replace uses platform-specific atomic swap syscalls on Linux/macOS and a temporary-directory rollback strategy elsewhere; the new APIs are exported via sourcemeta/core/io.h.

_{🤖 Was this summary useful? React with 👍 or 👎}

[augmentcode]

Review completed. 3 suggestions posted.

Comment augment review to trigger a new review at any time.

[augmentcode]

On Linux/macOS, a failure of renameat2(..., RENAME_EXCHANGE) / renameatx_np(..., RENAME_SWAP) throws immediately, even for ENOSYS/EINVAL cases where an atomic swap isn’t available but a non-atomic replace could still work. This seems to conflict with the “atomic swap when possible” contract.

Severity: medium

_{🤖 Was this useful? React with 👍 or 👎, or 🚀 if it prevented an incident/outage.}

[augmentcode]

If std::filesystem::rename(backup.path(), original) throws during rollback, backup’s destructor will still remove_all the backup directory, potentially deleting the last remaining copy of original. Consider guarding cleanup so rollback failures don’t turn into data loss.

Severity: high

_{🤖 Was this useful? React with 👍 or 👎, or 🚀 if it prevented an incident/outage.}