Skip to content

Merge BuildAdapterFilesystem and src/index/adapter.h#678

Merged
jviotti merged 1 commit intomainfrom
simpler-adapter
Feb 25, 2026
Merged

Merge BuildAdapterFilesystem and src/index/adapter.h#678
jviotti merged 1 commit intomainfrom
simpler-adapter

Conversation

@jviotti
Copy link
Member

@jviotti jviotti commented Feb 25, 2026

Signed-off-by: Juan Cruz Viotti jv@jviotti.com

Copy link

@cubic-dev-ai cubic-dev-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 8 files

@augmentcode
Copy link

augmentcode bot commented Feb 25, 2026

🤖 Augment PR Summary

Summary: This PR merges the index-specific filesystem adapter into the shared build adapter.

Changes:

  • Refactors BuildAdapterFilesystem to be constructed with a root directory and to resolve/write dependency paths relative to that root
  • Standardizes dependency files to use a fixed .deps extension (removing custom extension support)
  • Removes src/index/adapter.h and updates the index binary to use BuildAdapterFilesystem directly
  • Updates unit/e2e tests to pass an explicit root directory when constructing the adapter

Technical Notes: Relative dependency entries are now expanded with weakly_canonical(root / dep) when reading, while dependencies under the root are persisted as relative paths when writing.

🤖 Was this summary useful? React with 👍 or 👎

Copy link

@augmentcode augmentcode bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review completed. 1 suggestions posted.

Fix All in Augment

Comment augment review to trigger a new review at any time.

Signed-off-by: Juan Cruz Viotti <jv@jviotti.com>
@jviotti jviotti merged commit 05be9db into main Feb 25, 2026
5 checks passed
@jviotti jviotti deleted the simpler-adapter branch February 25, 2026 21:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant