-
Notifications
You must be signed in to change notification settings - Fork 24
CLI: add stdin support for instance validation #614
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
ddb8312 to
9a040d7
Compare
|
Hi @jviotti , I’ve opened this PR and would appreciate a review when you have time. Thanks! |
|
Hey @Vaibhav701161 , sorry for the delay. It has been a hectic week. I'll try to get into it today |
|
I like the idea but I think there are some things to iron out:
I think for consistency, we can require the The other problem here will be line numbers. We should make sure all relevant commands handle standard input while still reporting line/column information and potentially some "special" file path like |
Signed-off-by: Vaibhav mittal <vaibhavmittal929@gmail.com>
Signed-off-by: Vaibhav mittal <vaibhavmittal929@gmail.com>
Signed-off-by: Vaibhav mittal <vaibhavmittal929@gmail.com>
Signed-off-by: Vaibhav mittal <vaibhavmittal929@gmail.com>
Signed-off-by: Vaibhav mittal <vaibhavmittal929@gmail.com>
4d5ff3f to
112b374
Compare
Signed-off-by: Vaibhav mittal <vaibhavmittal929@gmail.com>
Signed-off-by: Vaibhav mittal <vaibhavmittal929@gmail.com>
|
Hey @jviotti , thanks a lot for the feedback. I’ve pushed an updated iteration that tries to address the concerns you mentioned:
|
Adds stdin support for instance input to enable real-time editor diagnostics.
Fixes(#537)
src/input.h(JSON-first, YAML fallback).validateaccepts instances from stdin only; schemas must be file paths.$refagainst the current working directory.test/validate/pass_stdin.sh.sourcemeta/studio#61; addressessourcemeta/jsonschema#537.Refs: sourcemeta/studio#61, #537
*

Build and test: