Conversation
Signed-off-by: Juan Cruz Viotti <jv@jviotti.com>
🤖 Augment PR SummarySummary: This PR upgrades the vendored Changes:
Technical Notes: Test executables now rely on 🤖 Was this summary useful? React with 👍 or 👎 |
| target_link_libraries(sourcemeta_core_test | ||
| PUBLIC sourcemeta::core::numeric) | ||
| target_link_libraries(sourcemeta_core_test | ||
| PRIVATE sourcemeta::core::options) |
There was a problem hiding this comment.
vendor/core/src/lang/test/CMakeLists.txt:11: sourcemeta_core_test uses sourcemeta::core::Options and sourcemeta::core::stacktrace_on_crash(), but both dependencies are linked as PRIVATE here; in static builds this can leave downstream test executables (that only link sourcemeta::core::test) with unresolved symbols. Can we confirm these dependencies are propagated to consumers (or otherwise guaranteed on the final link line)?
Severity: high
🤖 Was this useful? React with 👍 or 👎, or 🚀 if it prevented an incident/outage.
Signed-off-by: Juan Cruz Viotti jv@jviotti.com