Skip to content

Upgrade Core and Blaze#924

Merged
jviotti merged 1 commit into
mainfrom
no-gtest
Jul 1, 2026
Merged

Upgrade Core and Blaze#924
jviotti merged 1 commit into
mainfrom
no-gtest

Conversation

@jviotti

@jviotti jviotti commented Jul 1, 2026

Copy link
Copy Markdown
Member

Signed-off-by: Juan Cruz Viotti jv@jviotti.com

Review in cubic

Signed-off-by: Juan Cruz Viotti <jv@jviotti.com>

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 134 files

Re-trigger cubic

@jviotti jviotti merged commit de6cc36 into main Jul 1, 2026
13 checks passed
@jviotti jviotti deleted the no-gtest branch July 1, 2026 17:54
@augmentcode

augmentcode Bot commented Jul 1, 2026

Copy link
Copy Markdown
🤖 Augment PR Summary

Summary: This PR upgrades the vendored sourcemeta/core and sourcemeta/blaze dependencies and migrates JSONBinPack’s test suite away from GoogleTest.

Changes:

  • Bumps Core and Blaze revisions in DEPENDENCIES.
  • Removes Core’s bundled GoogleTest sources from vendor/core/vendor/googletest (large deletion).
  • Updates cmake/FindCore.cmake to stop configuring Core’s GoogleTest-related knobs.
  • Introduces/uses Core’s minimal test framework (<sourcemeta/core/test.h>) and its TEST(...)/EXPECT_* macros.
  • Switches unit-test CMake wiring from sourcemeta_googletest to sourcemeta_test for compiler/runtime suites.
  • Rewrites former EXPECT_THROW-style checks into explicit try/catch blocks with FAIL() and additional assertions.
  • Applies the test harness migration consistently across compiler and runtime test sources.

Technical Notes: Test executables now rely on sourcemeta::core::test_main for the default entry point and emit TAP-style output via Core’s runner.

🤖 Was this summary useful? React with 👍 or 👎

@augmentcode augmentcode Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review completed. 1 suggestion posted.

Fix All in Augment

Comment augment review to trigger a new review at any time.

target_link_libraries(sourcemeta_core_test
PUBLIC sourcemeta::core::numeric)
target_link_libraries(sourcemeta_core_test
PRIVATE sourcemeta::core::options)

@augmentcode augmentcode Bot Jul 1, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

vendor/core/src/lang/test/CMakeLists.txt:11: sourcemeta_core_test uses sourcemeta::core::Options and sourcemeta::core::stacktrace_on_crash(), but both dependencies are linked as PRIVATE here; in static builds this can leave downstream test executables (that only link sourcemeta::core::test) with unresolved symbols. Can we confirm these dependencies are propagated to consumers (or otherwise guaranteed on the final link line)?

Severity: high

Fix This in Augment

🤖 Was this useful? React with 👍 or 👎, or 🚀 if it prevented an incident/outage.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant