Conversation
Signed-off-by: Juan Cruz Viotti <jv@jviotti.com>
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
🤖 Augment PR SummarySummary: Updates the vendored CPR (C++ Requests) dependency to v1.14.2. Changes:
Technical Notes: This is primarily a vendor upgrade; most behavioral changes are internal safety/maintainability adjustments in CPR’s curl resource management and error mapping. 🤖 Was this summary useful? React with 👍 or 👎 |
![augmentcode[bot]](https://avatars.githubusercontent.com/in/1027498?s=60&v=4){kind=small}
| } // namespace cpr | ||
| } | ||
|
|
||
| CurlHolder::CurlHolder(CurlHolder&& old) noexcept : handle(old.handle), chunk(old.chunk), resolveCurlList(old.resolveCurlList), multipart(old.multipart), error(std::move(old.error)) { |
There was a problem hiding this comment.
CurlHolder is now movable, but if the CURL* has CURLOPT_ERRORBUFFER set to old.error.data(), moving will leave the handle pointing at the moved-from buffer, which can dangle once old is destroyed. Consider ensuring the moved-to handle’s error-buffer pointer remains valid (or documenting that CurlHolder must not be moved after configuring the handle).
Severity: medium
Other Locations
vendor/cpr/cpr/curlholder.cpp:40
🤖 Was this useful? React with 👍 or 👎, or 🚀 if it prevented an incident/outage.
| } | ||
| } | ||
|
|
||
| } // namespace cpr No newline at end of file |
There was a problem hiding this comment.
This file appears to be missing a trailing newline (diff shows No newline at end of file), which can cause noisy diffs and occasionally trip tooling.
Severity: low
🤖 Was this useful? React with 👍 or 👎, or 🚀 if it prevented an incident/outage.
Signed-off-by: Juan Cruz Viotti <jv@jviotti.com>
1 participant
Signed-off-by: Juan Cruz Viotti jv@jviotti.com