Skip to content

Minor CMake fixes to accomodate for Meson - #2780

Merged
jviotti merged 3 commits into
mainfrom
meson-fixes
Sep 2, 2026
Merged

Minor CMake fixes to accomodate for Meson#2780
jviotti merged 3 commits into
mainfrom
meson-fixes

Conversation

@jviotti

@jviotti jviotti commented Sep 2, 2026

Copy link
Copy Markdown
Member

See: sourcemeta/blaze#1024
Signed-off-by: Juan Cruz Viotti jv@jviotti.com

Review in cubic

See: sourcemeta/blaze#1024
Signed-off-by: Juan Cruz Viotti <jv@jviotti.com>
@augmentcode

augmentcode Bot commented Sep 2, 2026

Copy link
Copy Markdown
🤖 Augment PR Summary

Summary: This PR adjusts CMake export metadata to improve consumption by Meson.

Changes:

  • Replaces the exported Threads::Threads dependency in bundled mimalloc with its resolved link item.
  • Removes the corresponding find_dependency(Threads) call from the generated Mimalloc package config.
  • Adds a deferred export pass that unwraps static-library $<LINK_ONLY:...> dependencies.
  • Runs that pass after component CMakeLists files finish adding their link dependencies.
Technical Notes: The intent is to retain transitive static-link closure for build systems that trace CMake exports without evaluating generator expressions.

🤖 Was this summary useful? React with 👍 or 👎

@augmentcode augmentcode Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review completed. 1 suggestion posted.

Fix All in Augment

Comment augment review to trigger a new review at any time.

Comment thread cmake/FindMimalloc.cmake
find_package(Threads REQUIRED)
target_link_libraries(mimalloc PRIVATE Threads::Threads)
if(CMAKE_THREAD_LIBS_INIT)
target_link_libraries(mimalloc PRIVATE "${CMAKE_THREAD_LIBS_INIT}")

@augmentcode augmentcode Bot Sep 2, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CMAKE_THREAD_LIBS_INIT only represents the link item; it drops Threads::Threads' compile usage requirement (notably -pthread when that is how FindThreads succeeds). On platforms using that flag, mimalloc is now compiled without the thread feature macro/compile option even though it uses pthread APIs.

Severity: medium

Fix This in Augment

🤖 Was this useful? React with 👍 or 👎, or 🚀 if it prevented an incident/outage.

Signed-off-by: Juan Cruz Viotti <jv@jviotti.com>

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All reported issues were addressed

Reply with feedback, questions, or to request a fix.

Re-trigger cubic

Comment thread cmake/common/targets/library.cmake
Comment thread cmake/common/targets/library.cmake Outdated
Comment thread cmake/FindMimalloc.cmake
Signed-off-by: Juan Cruz Viotti <jv@jviotti.com>

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Benchmark (windows/msvc)

Details
Benchmark suite Current: 5246af4 Previous: 14af3c9 Ratio
Regex_Lower_S_Or_Upper_S_Asterisk 5.117028999999889 ns/iter 5.1833590000001095 ns/iter 0.99
Regex_Caret_Lower_S_Or_Upper_S_Asterisk_Dollar 5.11002899999994 ns/iter 5.021555357142659 ns/iter 1.02
Regex_Period_Asterisk 5.153108000000088 ns/iter 5.032564285714208 ns/iter 1.02
Regex_Group_Period_Asterisk_Group 5.099670000000174 ns/iter 5.111276999999745 ns/iter 1.00
Regex_Period_Plus 4.844272321428938 ns/iter 4.777980871602291 ns/iter 1.01
Regex_Period 4.800973671431032 ns/iter 4.810995179645566 ns/iter 1.00
Regex_Caret_Period_Plus_Dollar 4.8738308144507085 ns/iter 4.751601439225926 ns/iter 1.03
Regex_Caret_Group_Period_Plus_Group_Dollar 4.772095023386841 ns/iter 4.887322300197952 ns/iter 0.98
Regex_Caret_Period_Asterisk_Dollar 5.139808928571402 ns/iter 5.02034999999978 ns/iter 1.02
Regex_Caret_Group_Period_Asterisk_Group_Dollar 5.103144999999927 ns/iter 5.046300999999858 ns/iter 1.01
Regex_Caret_X_Hyphen 8.207547284787228 ns/iter 8.205641481224399 ns/iter 1.00
Regex_Period_Md_Dollar 47.1112778373041 ns/iter 46.91691399367959 ns/iter 1.00
Regex_Caret_Slash_Period_Asterisk 7.94595758928564 ns/iter 7.929384339600835 ns/iter 1.00
Regex_Caret_Period_Range_Dollar 5.751731999999947 ns/iter 5.788925892856765 ns/iter 0.99
Regex_Nested_Backtrack 57.74368000000436 ns/iter 94.41410000000019 ns/iter 0.61
JSON_Array_Of_Objects_Unique 573.2624999999985 ns/iter 586.2096428571765 ns/iter 0.98
JSON_Parse_1 9266.681398743824 ns/iter 8941.754724309632 ns/iter 1.04
JSON_Parse_Real 16165.209811671813 ns/iter 17083.20089285818 ns/iter 0.95
JSON_Parse_Decimal 11827.067187500263 ns/iter 12776.09642857109 ns/iter 0.93
JSON_Parse_Schema_ISO_Language 8038672.222222153 ns/iter 7647998.666667112 ns/iter 1.05
JSON_Parse_Integer 6200.891071428722 ns/iter 6425.690178571435 ns/iter 0.97
JSON_Parse_String_NonSSO_Plain 8175.70089285751 ns/iter 8163.898375453962 ns/iter 1.00
JSON_Parse_String_SSO_Plain 3889.330357143006 ns/iter 4108.090342695944 ns/iter 0.95
JSON_Parse_String_Escape_Heavy 21649.003124998955 ns/iter 23554.320822312406 ns/iter 0.92
JSON_Parse_Object_Short_Keys 13180.859014022391 ns/iter 14006.774076901063 ns/iter 0.94
JSON_Parse_Object_Scalar_Properties 6849.52790178566 ns/iter 6999.449776785888 ns/iter 0.98
JSON_Parse_Object_Array_Properties 11709.678125000344 ns/iter 11913.135937500208 ns/iter 0.98
JSON_Parse_Object_Object_Properties 11646.33214285666 ns/iter 12142.753571428753 ns/iter 0.96
JSON_Parse_Nested_Containers 80439.20758928584 ns/iter 84038.78398286231 ns/iter 0.96
JSON_From_String_Copy 65.0428399999953 ns/iter 69.3241517857146 ns/iter 0.94
JSON_From_String_Temporary 57.65941964286115 ns/iter 62.93276785714548 ns/iter 0.92
JSON_Number_To_Double 122.78471428571842 ns/iter 127.01012379418808 ns/iter 0.97
JSON_Object_At_Last_Key/8 7.649247767857074 ns/iter 8.59927678571434 ns/iter 0.89
JSON_Object_At_Last_Key/32 23.01705443061389 ns/iter 28.60450755762 ns/iter 0.80
JSON_Object_At_Last_Key/128 89.81773259741728 ns/iter 135.39754687499794 ns/iter 0.66
JSON_Object_At_Last_Key/512 427.00084796888393 ns/iter 540.0064285714633 ns/iter 0.79
JSON_Fast_Hash_Helm_Chart_Lock 103.17935937500522 ns/iter 107.12151753921854 ns/iter 0.96
JSON_Equality_Helm_Chart_Lock 212.09330749583233 ns/iter 221.43115624999155 ns/iter 0.96
JSON_Divisible_By_Decimal 306.7076354120856 ns/iter 307.32455357142135 ns/iter 1.00
JSON_String_Equal/10 10.390029687499691 ns/iter 10.689020312499409 ns/iter 0.97
JSON_String_Equal/100 11.68774374999959 ns/iter 11.944291071428786 ns/iter 0.98
JSON_String_Equal_Small_By_Perfect_Hash/10 2.5200446428572474 ns/iter 2.5168299095905478 ns/iter 1.00
JSON_String_Equal_Small_By_Runtime_Perfect_Hash/10 15.115856148778704 ns/iter 14.450809756916112 ns/iter 1.05
JSON_String_Fast_Hash/10 6.590206473214368 ns/iter 6.713252232142888 ns/iter 0.98
JSON_String_Fast_Hash/100 6.590130357142954 ns/iter 6.63785714285733 ns/iter 0.99
JSON_String_Key_Hash/10 5.352649999999812 ns/iter 5.501815000000079 ns/iter 0.97
JSON_String_Key_Hash/100 11.933326785713762 ns/iter 11.887953571428307 ns/iter 1.00
JSON_Object_Defines_Miss_Same_Length 4.7806312606712345 ns/iter 4.750448304631516 ns/iter 1.01
JSON_Object_Defines_Miss_Too_Small 4.724863403403857 ns/iter 5.121763999999871 ns/iter 0.92
JSON_Object_Defines_Miss_Too_Large 4.823587510767227 ns/iter 4.960403416285498 ns/iter 0.97
Pointer_Object_Traverse 70.84235714285926 ns/iter 71.81594866071553 ns/iter 0.99
Pointer_Object_Try_Traverse 71.59729910714167 ns/iter 71.18809821428381 ns/iter 1.01
Pointer_Push_Back_Pointer_To_Weak_Pointer 170.4205357142869 ns/iter 193.6208476447223 ns/iter 0.88
Pointer_Walker_Schema_ISO_Language 12770323.214285538 ns/iter 11066713.33333376 ns/iter 1.15
Pointer_Maybe_Tracked_Deeply_Nested/0 2586852.966101539 ns/iter 2488671.0714286305 ns/iter 1.04
Pointer_Maybe_Tracked_Deeply_Nested/1 3797231.8435754967 ns/iter 3786112.2905028095 ns/iter 1.00
Pointer_Position_Tracker_Get_Deeply_Nested 536.771604758365 ns/iter 548.0002934668694 ns/iter 0.98
JSONPath_Descendant_Filter_Nested 2412.93045431885 ns/iter 2403.5715361925195 ns/iter 1.00
URITemplateRouter_Create 41094.90453252842 ns/iter 42101.63658522584 ns/iter 0.98
URITemplateRouter_Match 234.5041144526557 ns/iter 232.9322499999975 ns/iter 1.01
URITemplateRouter_Match_BasePath 264.65282431484945 ns/iter 266.8534895916652 ns/iter 0.99
URITemplateRouterView_Restore 34094.67197014171 ns/iter 35121.027303083516 ns/iter 0.97
URITemplateRouterView_Match 184.06456107718788 ns/iter 182.15800733554565 ns/iter 1.01
URITemplateRouterView_Match_BasePath 207.71851751256114 ns/iter 210.44213346240159 ns/iter 0.99
URITemplateRouterView_Arguments 532.1806000000038 ns/iter 546.4979000000199 ns/iter 0.97
JSONL_Parse_Large 33002495.000002343 ns/iter 33549561.904760055 ns/iter 0.98
JSONL_Parse_Large_GZIP 33562279.99999817 ns/iter 33670342.857140854 ns/iter 1.00
JSONLD_Catalog_Annotation_List_Populate 3242419.248826276 ns/iter 3127594.1964284168 ns/iter 1.04
JSONLD_Catalog_Materialize 9339709.333333606 ns/iter 8326893.333333551 ns/iter 1.12
HTML_Build_Table_100000 94238271.42856972 ns/iter 91893214.2857167 ns/iter 1.03
HTML_Render_Table_100000 8084034.444444418 ns/iter 7659422.222222171 ns/iter 1.06
GZIP_Compress_ISO_Language_Set_3_Locations 36684726.31578892 ns/iter 36162110.52631295 ns/iter 1.01
GZIP_Decompress_ISO_Language_Set_3_Locations 10044904.000000468 ns/iter 10165231.249999352 ns/iter 0.99
GZIP_Compress_ISO_Language_Set_3_Schema 2129197.1014493094 ns/iter 2101133.623188511 ns/iter 1.01
GZIP_Decompress_ISO_Language_Set_3_Schema 655737.6785714045 ns/iter 618812.5892857142 ns/iter 1.06
JOSE_VerifySignature_RS256 21531.656249999643 ns/iter 21439.846874999446 ns/iter 1.00
JOSE_VerifySignature_ES512 1370960.8433734353 ns/iter 1384266.2650601934 ns/iter 0.99

This comment was automatically generated by workflow using github-action-benchmark.

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Benchmark (linux/gcc)

Details
Benchmark suite Current: 5246af4 Previous: 14af3c9 Ratio
JOSE_VerifySignature_RS256 22033.632206508337 ns/iter 22492.413542926843 ns/iter 0.98
JOSE_VerifySignature_ES512 575796.7733664047 ns/iter 576199.8421052651 ns/iter 1.00
GZIP_Compress_ISO_Language_Set_3_Locations 36781519.26315746 ns/iter 36535172.210524015 ns/iter 1.01
GZIP_Decompress_ISO_Language_Set_3_Locations 4449754.411392114 ns/iter 4194942.420118159 ns/iter 1.06
GZIP_Compress_ISO_Language_Set_3_Schema 2043477.0474778381 ns/iter 2039730.8629737177 ns/iter 1.00
GZIP_Decompress_ISO_Language_Set_3_Schema 380347.5718171936 ns/iter 376837.6616379241 ns/iter 1.01
HTML_Build_Table_100000 54950946.66666489 ns/iter 54797603.50000144 ns/iter 1.00
HTML_Render_Table_100000 1951131.0280112596 ns/iter 1931977.3808218725 ns/iter 1.01
JSONLD_Catalog_Annotation_List_Populate 680813.9580838603 ns/iter 677947.0784124386 ns/iter 1.00
JSONLD_Catalog_Materialize 4076198.4615382515 ns/iter 3461904.069306929 ns/iter 1.18
JSONL_Parse_Large 9861484.442857156 ns/iter 9837509.957746122 ns/iter 1.00
JSONL_Parse_Large_GZIP 11233872.225806218 ns/iter 11243139.555555595 ns/iter 1.00
URITemplateRouter_Create 21537.227331508522 ns/iter 21116.45126282517 ns/iter 1.02
URITemplateRouter_Match 154.6644849037616 ns/iter 157.32629472068137 ns/iter 0.98
URITemplateRouter_Match_BasePath 182.2423091784499 ns/iter 184.55023994813126 ns/iter 0.99
URITemplateRouterView_Restore 8704.21420959173 ns/iter 8404.241598525603 ns/iter 1.04
URITemplateRouterView_Match 122.7015250234496 ns/iter 125.91355719374549 ns/iter 0.97
URITemplateRouterView_Match_BasePath 142.95926163653647 ns/iter 148.40974650980633 ns/iter 0.96
URITemplateRouterView_Arguments 471.3018623269514 ns/iter 479.79529860496217 ns/iter 0.98
JSONPath_Descendant_Filter_Nested 1609.5212168290043 ns/iter 1623.4834386128223 ns/iter 0.99
Pointer_Object_Traverse 22.96091208191539 ns/iter 23.17452531297153 ns/iter 0.99
Pointer_Object_Try_Traverse 25.873716668219615 ns/iter 25.883496628399513 ns/iter 1.00
Pointer_Push_Back_Pointer_To_Weak_Pointer 127.19217255810912 ns/iter 150.2696033921338 ns/iter 0.85
Pointer_Walker_Schema_ISO_Language 1608395.7279411887 ns/iter 1417382.2815734507 ns/iter 1.13
Pointer_Maybe_Tracked_Deeply_Nested/0 1220560.308771929 ns/iter 1203314.0118845322 ns/iter 1.01
Pointer_Maybe_Tracked_Deeply_Nested/1 1703257.7135922757 ns/iter 1678007.4216867487 ns/iter 1.02
Pointer_Position_Tracker_Get_Deeply_Nested 603.5232850383317 ns/iter 602.4570550437682 ns/iter 1.00
JSON_Array_Of_Objects_Unique 471.2170908193325 ns/iter 466.7133616449632 ns/iter 1.01
JSON_Parse_1 5168.525154502583 ns/iter 5254.639108661292 ns/iter 0.98
JSON_Parse_Real 5518.953513018553 ns/iter 5891.00247260685 ns/iter 0.94
JSON_Parse_Decimal 10265.981556626448 ns/iter 10463.636461382419 ns/iter 0.98
JSON_Parse_Schema_ISO_Language 3690957.5578946667 ns/iter 3600276.5641027372 ns/iter 1.03
JSON_Parse_Integer 3788.7880631790904 ns/iter 3797.0194671075237 ns/iter 1.00
JSON_Parse_String_NonSSO_Plain 3354.1648791374932 ns/iter 3270.3140847503614 ns/iter 1.03
JSON_Parse_String_SSO_Plain 3015.0559542869814 ns/iter 2978.19528673973 ns/iter 1.01
JSON_Parse_String_Escape_Heavy 16765.415240570117 ns/iter 16667.033957168005 ns/iter 1.01
JSON_Parse_Object_Short_Keys 8519.952788140037 ns/iter 8697.528580298334 ns/iter 0.98
JSON_Parse_Object_Scalar_Properties 4330.744121774869 ns/iter 4290.920596677393 ns/iter 1.01
JSON_Parse_Object_Array_Properties 6367.984517977467 ns/iter 6490.7300817374135 ns/iter 0.98
JSON_Parse_Object_Object_Properties 6447.027809270696 ns/iter 6547.8330844365655 ns/iter 0.98
JSON_Parse_Nested_Containers 38778.050944854986 ns/iter 39082.81979131842 ns/iter 0.99
JSON_From_String_Copy 8.346901674691647 ns/iter 8.530152909558716 ns/iter 0.98
JSON_From_String_Temporary 7.350611869252314 ns/iter 7.432116293700513 ns/iter 0.99
JSON_Number_To_Double 22.15321326514438 ns/iter 22.141107854976863 ns/iter 1.00
JSON_Object_At_Last_Key/8 5.612174949983238 ns/iter 5.6118870046534575 ns/iter 1.00
JSON_Object_At_Last_Key/32 21.782407387182207 ns/iter 21.573092897187546 ns/iter 1.01
JSON_Object_At_Last_Key/128 87.79974818874466 ns/iter 87.84617533922084 ns/iter 1.00
JSON_Object_At_Last_Key/512 397.2103668879966 ns/iter 392.9513225471613 ns/iter 1.01
JSON_Fast_Hash_Helm_Chart_Lock 83.31783405836376 ns/iter 87.5871722643692 ns/iter 0.95
JSON_Equality_Helm_Chart_Lock 147.91522779592293 ns/iter 147.816200597061 ns/iter 1.00
JSON_Divisible_By_Decimal 265.046202824265 ns/iter 259.9211277288661 ns/iter 1.02
JSON_String_Equal/10 5.417814612732015 ns/iter 5.413802686553402 ns/iter 1.00
JSON_String_Equal/100 6.05807410345201 ns/iter 6.053763141149578 ns/iter 1.00
JSON_String_Equal_Small_By_Perfect_Hash/10 0.7503550964652936 ns/iter 0.7487961632102975 ns/iter 1.00
JSON_String_Equal_Small_By_Runtime_Perfect_Hash/10 25.193388321849074 ns/iter 25.189277731158565 ns/iter 1.00
JSON_String_Fast_Hash/10 3.1543041294227634 ns/iter 3.1515925122869084 ns/iter 1.00
JSON_String_Fast_Hash/100 3.1548405633993557 ns/iter 3.151445729390428 ns/iter 1.00
JSON_String_Key_Hash/10 1.2467426981678493 ns/iter 1.2469169070528048 ns/iter 1.00
JSON_String_Key_Hash/100 12.45415758385005 ns/iter 12.442195274444673 ns/iter 1.00
JSON_Object_Defines_Miss_Same_Length 3.1162721268913 ns/iter 3.112552362001312 ns/iter 1.00
JSON_Object_Defines_Miss_Too_Small 3.425971224609026 ns/iter 3.424822354054035 ns/iter 1.00
JSON_Object_Defines_Miss_Too_Large 3.1139471613314287 ns/iter 3.1151134334775845 ns/iter 1.00
Regex_Lower_S_Or_Upper_S_Asterisk 0.6227065888778273 ns/iter 0.622476970901485 ns/iter 1.00
Regex_Caret_Lower_S_Or_Upper_S_Asterisk_Dollar 0.6229480599842674 ns/iter 0.6226423562171957 ns/iter 1.00
Regex_Period_Asterisk 0.6228747928210037 ns/iter 0.6231748211671304 ns/iter 1.00
Regex_Group_Period_Asterisk_Group 0.6253607756894911 ns/iter 0.6246405285579544 ns/iter 1.00
Regex_Period_Plus 0.6232122580301778 ns/iter 0.6228027953724716 ns/iter 1.00
Regex_Period 0.6232519028793734 ns/iter 0.6225874471965546 ns/iter 1.00
Regex_Caret_Period_Plus_Dollar 0.622720828902135 ns/iter 0.6240272818940259 ns/iter 1.00
Regex_Caret_Group_Period_Plus_Group_Dollar 0.6228572857759601 ns/iter 0.623269799299602 ns/iter 1.00
Regex_Caret_Period_Asterisk_Dollar 0.6273524907672501 ns/iter 0.6228860759876728 ns/iter 1.01
Regex_Caret_Group_Period_Asterisk_Group_Dollar 0.6230711726344561 ns/iter 0.6226476856863471 ns/iter 1.00
Regex_Caret_X_Hyphen 4.0525994435162 ns/iter 4.051141927822434 ns/iter 1.00
Regex_Period_Md_Dollar 37.10600342471391 ns/iter 35.93902021009316 ns/iter 1.03
Regex_Caret_Slash_Period_Asterisk 4.362782441566379 ns/iter 4.369105033718798 ns/iter 1.00
Regex_Caret_Period_Range_Dollar 1.2458907858428627 ns/iter 1.2510926497569743 ns/iter 1.00
Regex_Nested_Backtrack 39.53944577973743 ns/iter 37.72795756041321 ns/iter 1.05

This comment was automatically generated by workflow using github-action-benchmark.

@jviotti
jviotti merged commit c9b8470 into main Sep 2, 2026
13 checks passed
@jviotti
jviotti deleted the meson-fixes branch September 2, 2026 20:51

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Benchmark (linux/llvm)

Details
Benchmark suite Current: 5246af4 Previous: 14af3c9 Ratio
Regex_Lower_S_Or_Upper_S_Asterisk 2.4616111832756937 ns/iter 2.197695507760546 ns/iter 1.12
Regex_Caret_Lower_S_Or_Upper_S_Asterisk_Dollar 2.4609805124132245 ns/iter 2.1908878621091623 ns/iter 1.12
Regex_Period_Asterisk 2.4610945951237806 ns/iter 2.1889358652783857 ns/iter 1.12
Regex_Group_Period_Asterisk_Group 2.4616280988151606 ns/iter 2.1963866737495885 ns/iter 1.12
Regex_Period_Plus 3.8664172897526936 ns/iter 3.7346522730331966 ns/iter 1.04
Regex_Period 3.8664608948537156 ns/iter 3.735141283734974 ns/iter 1.04
Regex_Caret_Period_Plus_Dollar 3.8691983046873677 ns/iter 3.7330258390611175 ns/iter 1.04
Regex_Caret_Group_Period_Plus_Group_Dollar 3.8666587187057555 ns/iter 3.7318558986632526 ns/iter 1.04
Regex_Caret_Period_Asterisk_Dollar 2.464161847466132 ns/iter 2.1945471252796516 ns/iter 1.12
Regex_Caret_Group_Period_Asterisk_Group_Dollar 2.6637467066620224 ns/iter 2.1924794912036054 ns/iter 1.21
Regex_Caret_X_Hyphen 5.6259900528631395 ns/iter 5.917476166725573 ns/iter 0.95
Regex_Period_Md_Dollar 26.23372198927223 ns/iter 27.235901299999963 ns/iter 0.96
Regex_Caret_Slash_Period_Asterisk 5.9747856358636895 ns/iter 5.603130942030929 ns/iter 1.07
Regex_Caret_Period_Range_Dollar 2.4659253793194056 ns/iter 2.4933780322648604 ns/iter 0.99
Regex_Nested_Backtrack 38.709277938996685 ns/iter 38.74801301268206 ns/iter 1.00
JSON_Array_Of_Objects_Unique 478.27170842564743 ns/iter 454.19442497038284 ns/iter 1.05
JSON_Parse_1 4324.2633229034 ns/iter 4489.217355276233 ns/iter 0.96
JSON_Parse_Real 5066.857281728384 ns/iter 5234.268495211348 ns/iter 0.97
JSON_Parse_Decimal 7384.993046849926 ns/iter 7412.730211639928 ns/iter 1.00
JSON_Parse_Schema_ISO_Language 3362611.3512196955 ns/iter 3276668.38139537 ns/iter 1.03
JSON_Parse_Integer 3740.4534838622935 ns/iter 3581.4874020068846 ns/iter 1.04
JSON_Parse_String_NonSSO_Plain 3059.210932086302 ns/iter 2968.7511276704845 ns/iter 1.03
JSON_Parse_String_SSO_Plain 2652.4637955257444 ns/iter 2578.125543594161 ns/iter 1.03
JSON_Parse_String_Escape_Heavy 11972.653760098025 ns/iter 11996.466823102437 ns/iter 1.00
JSON_Parse_Object_Short_Keys 7761.990189753854 ns/iter 7710.884951155973 ns/iter 1.01
JSON_Parse_Object_Scalar_Properties 3962.773022137499 ns/iter 3938.7875486292182 ns/iter 1.01
JSON_Parse_Object_Array_Properties 5485.119342880637 ns/iter 5254.072804031125 ns/iter 1.04
JSON_Parse_Object_Object_Properties 5486.729333219584 ns/iter 5230.009668333109 ns/iter 1.05
JSON_Parse_Nested_Containers 34743.12875897791 ns/iter 34687.77802546332 ns/iter 1.00
JSON_From_String_Copy 11.079707656476259 ns/iter 10.466619525891186 ns/iter 1.06
JSON_From_String_Temporary 10.084880110172387 ns/iter 9.831966110524323 ns/iter 1.03
JSON_Number_To_Double 23.339445353870182 ns/iter 24.321136763402105 ns/iter 0.96
JSON_Object_At_Last_Key/8 4.020379650660791 ns/iter 3.929540938382874 ns/iter 1.02
JSON_Object_At_Last_Key/32 13.541056477904009 ns/iter 12.248840262497577 ns/iter 1.11
JSON_Object_At_Last_Key/128 47.84662880303969 ns/iter 49.41360668201586 ns/iter 0.97
JSON_Object_At_Last_Key/512 357.73690124506953 ns/iter 383.57054374791244 ns/iter 0.93
JSON_Fast_Hash_Helm_Chart_Lock 66.09147669821563 ns/iter 54.47796433765453 ns/iter 1.21
JSON_Equality_Helm_Chart_Lock 155.15444154127096 ns/iter 156.82045291008436 ns/iter 0.99
JSON_Divisible_By_Decimal 259.60071923602857 ns/iter 253.60446522571615 ns/iter 1.02
JSON_String_Equal/10 5.827070135323326 ns/iter 5.918878570723844 ns/iter 0.98
JSON_String_Equal/100 6.332490516125411 ns/iter 6.543626380625635 ns/iter 0.97
JSON_String_Equal_Small_By_Perfect_Hash/10 1.0549829830192343 ns/iter 0.9350439029785635 ns/iter 1.13
JSON_String_Equal_Small_By_Runtime_Perfect_Hash/10 12.473378744638994 ns/iter 10.593256598826779 ns/iter 1.18
JSON_String_Fast_Hash/10 2.11032372626098 ns/iter 2.187621995627184 ns/iter 0.96
JSON_String_Fast_Hash/100 2.111682383698062 ns/iter 2.180904074154459 ns/iter 0.97
JSON_String_Key_Hash/10 2.4672706634664707 ns/iter 2.1835010130472248 ns/iter 1.13
JSON_String_Key_Hash/100 8.205728912672066 ns/iter 6.540320864552615 ns/iter 1.25
JSON_Object_Defines_Miss_Same_Length 4.219433780631649 ns/iter 3.427684364955828 ns/iter 1.23
JSON_Object_Defines_Miss_Too_Small 3.1960907048950493 ns/iter 3.136080478671803 ns/iter 1.02
JSON_Object_Defines_Miss_Too_Large 2.94119144060992 ns/iter 2.9039909574798726 ns/iter 1.01
Pointer_Object_Traverse 30.815901593054107 ns/iter 28.699121962025934 ns/iter 1.07
Pointer_Object_Try_Traverse 33.100903178926494 ns/iter 30.87848140149915 ns/iter 1.07
Pointer_Push_Back_Pointer_To_Weak_Pointer 183.0673447094408 ns/iter 142.84069609882644 ns/iter 1.28
Pointer_Walker_Schema_ISO_Language 1645206.2818627036 ns/iter 1541081.947939194 ns/iter 1.07
Pointer_Maybe_Tracked_Deeply_Nested/0 1272368.4329709928 ns/iter 1235916.948943673 ns/iter 1.03
Pointer_Maybe_Tracked_Deeply_Nested/1 1931049.3576825971 ns/iter 1691990.3023809488 ns/iter 1.14
Pointer_Position_Tracker_Get_Deeply_Nested 713.9042140733949 ns/iter 636.1014747662543 ns/iter 1.12
JSONPath_Descendant_Filter_Nested 1516.9773746059564 ns/iter 1561.2969221108854 ns/iter 0.97
URITemplateRouter_Create 21916.567865261593 ns/iter 24470.061011019687 ns/iter 0.90
URITemplateRouter_Match 171.6425180018399 ns/iter 181.27541492905877 ns/iter 0.95
URITemplateRouter_Match_BasePath 195.05053361250015 ns/iter 205.64268616841824 ns/iter 0.95
URITemplateRouterView_Restore 10185.722463848366 ns/iter 8241.325378077185 ns/iter 1.24
URITemplateRouterView_Match 144.94476635512098 ns/iter 141.23670978171765 ns/iter 1.03
URITemplateRouterView_Match_BasePath 165.37249350290872 ns/iter 162.93331093342508 ns/iter 1.01
URITemplateRouterView_Arguments 450.5799351789928 ns/iter 431.0777122446355 ns/iter 1.05
JSONL_Parse_Large 8643240.333332904 ns/iter 9001911.74025991 ns/iter 0.96
JSONL_Parse_Large_GZIP 10376739.999999778 ns/iter 10544001.772727238 ns/iter 0.98
JSONLD_Catalog_Annotation_List_Populate 600759.466895955 ns/iter 592003.9813874618 ns/iter 1.01
JSONLD_Catalog_Materialize 3912305.784530473 ns/iter 3444745.3921569935 ns/iter 1.14
HTML_Build_Table_100000 66558081.70000341 ns/iter 56703766.36363595 ns/iter 1.17
HTML_Render_Table_100000 2362015.6143789804 ns/iter 1780626.7729591995 ns/iter 1.33
GZIP_Compress_ISO_Language_Set_3_Locations 35956336.249998346 ns/iter 33485080.857144028 ns/iter 1.07
GZIP_Decompress_ISO_Language_Set_3_Locations 4310377.148148119 ns/iter 4085665.3294119546 ns/iter 1.06
GZIP_Compress_ISO_Language_Set_3_Schema 2143598.6349692703 ns/iter 1888117.3234501265 ns/iter 1.14
GZIP_Decompress_ISO_Language_Set_3_Schema 276729.7344677441 ns/iter 351760.28064842854 ns/iter 0.79
JOSE_VerifySignature_RS256 64024.84777625287 ns/iter 56762.014909649624 ns/iter 1.13
JOSE_VerifySignature_ES512 2666596.661596937 ns/iter 2422067.820689649 ns/iter 1.10

This comment was automatically generated by workflow using github-action-benchmark.

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Benchmark (macos/llvm)

Details
Benchmark suite Current: 5246af4 Previous: 14af3c9 Ratio
Regex_Lower_S_Or_Upper_S_Asterisk 2.4416925394690914 ns/iter 2.0558566288813864 ns/iter 1.19
Regex_Caret_Lower_S_Or_Upper_S_Asterisk_Dollar 2.1156976242682024 ns/iter 2.2008109310740958 ns/iter 0.96
Regex_Period_Asterisk 2.1409678706447473 ns/iter 2.0172929143205383 ns/iter 1.06
Regex_Group_Period_Asterisk_Group 2.160036382217627 ns/iter 2.034647877337778 ns/iter 1.06
Regex_Period_Plus 2.350758363358583 ns/iter 2.3668436740783787 ns/iter 0.99
Regex_Period 2.29730323855795 ns/iter 2.3616177023403604 ns/iter 0.97
Regex_Caret_Period_Plus_Dollar 2.357489428992838 ns/iter 2.532850616940956 ns/iter 0.93
Regex_Caret_Group_Period_Plus_Group_Dollar 2.283419490144319 ns/iter 2.3629257813255506 ns/iter 0.97
Regex_Caret_Period_Asterisk_Dollar 1.9629488381071303 ns/iter 1.9341871457315782 ns/iter 1.01
Regex_Caret_Group_Period_Asterisk_Group_Dollar 1.9153265431413107 ns/iter 2.379666983355669 ns/iter 0.80
Regex_Caret_X_Hyphen 6.965564021209627 ns/iter 7.701032086835618 ns/iter 0.90
Regex_Period_Md_Dollar 23.940224300631424 ns/iter 25.919940551894474 ns/iter 0.92
Regex_Caret_Slash_Period_Asterisk 5.5525475000001725 ns/iter 5.670742123911041 ns/iter 0.98
Regex_Caret_Period_Range_Dollar 2.650307084556351 ns/iter 2.4646192646211214 ns/iter 1.08
Regex_Nested_Backtrack 44.00101018548514 ns/iter 38.33361872009159 ns/iter 1.15
JSON_Array_Of_Objects_Unique 508.73738321594436 ns/iter 541.6629510671395 ns/iter 0.94
JSON_Parse_1 3957.523910628775 ns/iter 3925.8874993564154 ns/iter 1.01
JSON_Parse_Real 6505.39422259255 ns/iter 6378.9420697834485 ns/iter 1.02
JSON_Parse_Decimal 6627.454956280703 ns/iter 7036.131438890205 ns/iter 0.94
JSON_Parse_Schema_ISO_Language 2748191.058181791 ns/iter 2670355.599236648 ns/iter 1.03
JSON_Parse_Integer 3857.848521666628 ns/iter 4457.687767655077 ns/iter 0.87
JSON_Parse_String_NonSSO_Plain 3781.6842415528567 ns/iter 4384.918585789219 ns/iter 0.86
JSON_Parse_String_SSO_Plain 2152.0982707718254 ns/iter 2371.9470991183653 ns/iter 0.91
JSON_Parse_String_Escape_Heavy 19956.420674876517 ns/iter 20735.85398023057 ns/iter 0.96
JSON_Parse_Object_Short_Keys 7141.426328642678 ns/iter 6697.297936593248 ns/iter 1.07
JSON_Parse_Object_Scalar_Properties 3497.674156223999 ns/iter 3664.9572883466517 ns/iter 0.95
JSON_Parse_Object_Array_Properties 4473.170611045867 ns/iter 4345.562756003915 ns/iter 1.03
JSON_Parse_Object_Object_Properties 4130.2271099028685 ns/iter 5029.349596281367 ns/iter 0.82
JSON_Parse_Nested_Containers 32618.532904654658 ns/iter 35423.98625973891 ns/iter 0.92
JSON_From_String_Copy 13.876290445630739 ns/iter 13.349350517269912 ns/iter 1.04
JSON_From_String_Temporary 8.112630312586836 ns/iter 9.039423984342532 ns/iter 0.90
JSON_Number_To_Double 42.52822960182209 ns/iter 43.8344509333591 ns/iter 0.97
JSON_Object_At_Last_Key/8 4.83584199892238 ns/iter 5.186078465723726 ns/iter 0.93
JSON_Object_At_Last_Key/32 14.349988080755363 ns/iter 20.084354190304975 ns/iter 0.71
JSON_Object_At_Last_Key/128 69.23028928797423 ns/iter 76.18731826856029 ns/iter 0.91
JSON_Object_At_Last_Key/512 243.41849237047342 ns/iter 303.241743059844 ns/iter 0.80
JSON_Fast_Hash_Helm_Chart_Lock 77.13822407187095 ns/iter 85.63191793743896 ns/iter 0.90
JSON_Equality_Helm_Chart_Lock 199.53438970284623 ns/iter 263.09617612724463 ns/iter 0.76
JSON_Divisible_By_Decimal 188.97487233879502 ns/iter 286.0829118477421 ns/iter 0.66
JSON_String_Equal/10 7.1699981874208465 ns/iter 10.718977971953878 ns/iter 0.67
JSON_String_Equal/100 7.273809785307421 ns/iter 9.457519920561758 ns/iter 0.77
JSON_String_Equal_Small_By_Perfect_Hash/10 0.3878835057706799 ns/iter 0.4549893770943861 ns/iter 0.85
JSON_String_Equal_Small_By_Runtime_Perfect_Hash/10 3.8631172803386193 ns/iter 5.456887080000001 ns/iter 0.71
JSON_String_Fast_Hash/10 2.5043722074655586 ns/iter 4.40700278321417 ns/iter 0.57
JSON_String_Fast_Hash/100 2.4386538112263296 ns/iter 3.579198043134501 ns/iter 0.68
JSON_String_Key_Hash/10 2.017621726932756 ns/iter 2.773393679651961 ns/iter 0.73
JSON_String_Key_Hash/100 2.835850530038666 ns/iter 3.5006405354822503 ns/iter 0.81
JSON_Object_Defines_Miss_Same_Length 3.675023642112989 ns/iter 4.58992106849856 ns/iter 0.80
JSON_Object_Defines_Miss_Too_Small 3.157515011324628 ns/iter 4.228693388615171 ns/iter 0.75
JSON_Object_Defines_Miss_Too_Large 3.205885401221225 ns/iter 4.048993480598685 ns/iter 0.79
Pointer_Object_Traverse 22.81206277029379 ns/iter 36.32044354808504 ns/iter 0.63
Pointer_Object_Try_Traverse 38.75548269904043 ns/iter 67.88966579332661 ns/iter 0.57
Pointer_Push_Back_Pointer_To_Weak_Pointer 166.39677663529957 ns/iter 298.4182025411428 ns/iter 0.56
Pointer_Walker_Schema_ISO_Language 1333038.8287938593 ns/iter 2509551.7045454844 ns/iter 0.53
Pointer_Maybe_Tracked_Deeply_Nested/0 937163.5188834064 ns/iter 1524946.9814813181 ns/iter 0.61
Pointer_Maybe_Tracked_Deeply_Nested/1 1309256.77634005 ns/iter 2124584.353260819 ns/iter 0.62
Pointer_Position_Tracker_Get_Deeply_Nested 415.66286944933216 ns/iter 561.1483862166294 ns/iter 0.74
JSONPath_Descendant_Filter_Nested 1374.409220396143 ns/iter 1671.0591868665515 ns/iter 0.82
URITemplateRouter_Create 25053.31421966042 ns/iter 30659.029846609912 ns/iter 0.82
URITemplateRouter_Match 211.28803745225036 ns/iter 239.83295870223972 ns/iter 0.88
URITemplateRouter_Match_BasePath 247.260395184413 ns/iter 294.0133563691774 ns/iter 0.84
URITemplateRouterView_Restore 10875.330554596281 ns/iter 23350.170915701186 ns/iter 0.47
URITemplateRouterView_Match 156.11322113415196 ns/iter 195.4941511843697 ns/iter 0.80
URITemplateRouterView_Match_BasePath 184.17135348937742 ns/iter 235.54507963836622 ns/iter 0.78
URITemplateRouterView_Arguments 663.5316779787879 ns/iter 880.126851930646 ns/iter 0.75
JSONL_Parse_Large 7679690.829999685 ns/iter 11356989.150684755 ns/iter 0.68
JSONL_Parse_Large_GZIP 9043498.511905076 ns/iter 16993481.07272685 ns/iter 0.53
JSONLD_Catalog_Annotation_List_Populate 574731.2500000135 ns/iter 950329.6712328031 ns/iter 0.60
JSONLD_Catalog_Materialize 2290868.4872725806 ns/iter 4051995.4337899075 ns/iter 0.57
HTML_Build_Table_100000 39303703.47058657 ns/iter 79286100.00000162 ns/iter 0.50
HTML_Render_Table_100000 2193639.189189175 ns/iter 2949842.574545404 ns/iter 0.74
GZIP_Compress_ISO_Language_Set_3_Locations 34196611.84210554 ns/iter 32121856.750002563 ns/iter 1.06
GZIP_Decompress_ISO_Language_Set_3_Locations 4698373.466257644 ns/iter 5306950.10884363 ns/iter 0.89
GZIP_Compress_ISO_Language_Set_3_Schema 2035980.8441558664 ns/iter 1927703.082191802 ns/iter 1.06
GZIP_Decompress_ISO_Language_Set_3_Schema 354063.7562088273 ns/iter 396468.6489422147 ns/iter 0.89
JOSE_VerifySignature_RS256 31468.47504806978 ns/iter 50734.83749999923 ns/iter 0.62
JOSE_VerifySignature_ES512 1306765.2426470828 ns/iter 1762661.0818858014 ns/iter 0.74

This comment was automatically generated by workflow using github-action-benchmark.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant