Skip to content

Fix LibDeflate sudden ARM issues on GitHub Actions #2360

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jviotti merged 2 commits into from
Apr 24, 2026
+24 −0
Merged

Fix LibDeflate sudden ARM issues on GitHub Actions #2360

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6ab9c86
Fix LibDeflate sudden ARM issues on GitHub Actions
jviotti Apr 24, 2026
3389050
Fix
jviotti Apr 24, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 24 additions & 0 deletions cmake/FindLibDeflate.cmake
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,30 @@ if(NOT LibDeflate_FOUND)
add_library(libdeflate STATIC ${LIBDEFLATE_SOURCES})
sourcemeta_add_default_options(PRIVATE libdeflate)

# Check if the assembler supports ARM dot-product (udot) instructions.
# GCC 14+ assumes binutils is new enough, but some CI environments
# pair GCC 14 with older binutils that lack udot support
if(CMAKE_SYSTEM_PROCESSOR MATCHES "aarch64|arm64|ARM64")
include(CheckCSourceCompiles)
set(LIBDEFLATE_SAVED_CMAKE_REQUIRED_FLAGS "${CMAKE_REQUIRED_FLAGS}")
set(CMAKE_REQUIRED_FLAGS "${CMAKE_REQUIRED_FLAGS} -march=armv8.2-a+dotprod")
check_c_source_compiles("
#include <arm_neon.h>
int main(void) {
uint32x4_t a = vdupq_n_u32(0);
uint8x16_t b = vdupq_n_u8(0);
uint8x16_t c = vdupq_n_u8(0);
a = vdotq_u32(a, b, c);
return 0;
}
" LIBDEFLATE_HAS_DOTPROD_ASSEMBLER)
set(CMAKE_REQUIRED_FLAGS "${LIBDEFLATE_SAVED_CMAKE_REQUIRED_FLAGS}")
if(NOT LIBDEFLATE_HAS_DOTPROD_ASSEMBLER)
target_compile_definitions(libdeflate PRIVATE
LIBDEFLATE_ASSEMBLER_DOES_NOT_SUPPORT_DOTPROD)
endif()
endif()

target_include_directories(libdeflate PUBLIC
"$<BUILD_INTERFACE:${LIBDEFLATE_DIR}>"
"$<INSTALL_INTERFACE:${CMAKE_INSTALL_INCLUDEDIR}>")
Expand Down
Loading