reimplement OpenSHC::Input::MouseState 100% - #211
Draft
TheRedDaemon wants to merge 18 commits into
Draft
Conversation
TheRedDaemon
added
the
in progress
TheRedDaemon
added
declaration/type change
TheRedDaemon
changed the title
gynt
reviewed
Aug 31, 2026
| namespace Input { | ||
| namespace Mouse { | ||
| typedef byte ClickTypeBitMaskEnumByte; | ||
| typedef char ClickTypeBitMaskEnumByte; |
Contributor
There was a problem hiding this comment.
You sure? Changing this would mean changing all enum bytes to enum chars, which is fine I guess, since original enum is also usually int (not uint). Just want to be sure before I implement such a large change.
Contributor
Author
There was a problem hiding this comment.
Yes. While a while, I clearly remember that I was hesitant and tested around, but it is a char.
gynt
reviewed
Aug 31, 2026
| BOOLEnum leftClickState; // 0x00000040 length: 4 | ||
| BOOLEnum midClickState; // 0x00000044 length: 4 | ||
| BOOLEnum rightClickState; // 0x00000048 length: 4 | ||
| int rightClickState; // 0x00000048 length: 4 |
Contributor
There was a problem hiding this comment.
You do use TRUE and FALSE in the .cpp files. Are you sure it should be an int?
Contributor
Author
There was a problem hiding this comment.
Since this is just an alias for and int it actually has no effect on the logic. I reverted the change, no idea why I did this.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.