Reimpl/simple functions set 1 - #199
Draft
gynt wants to merge 61 commits into
Draft
Conversation
gynt
force-pushed
the
reimpl/simple-functions-set-1
branch
2 times, most recently
from
August 23, 2026 02:19
dbc6c35 to
96be230
Compare
gynt
commented
Aug 23, 2026
| @@ -1,4 +1,4 @@ | |||
| #include "../SoundSystem.func.hpp" | |||
Contributor
Author
There was a problem hiding this comment.
My clang-format fixes this relative import to its absolute version. Why doesn't yours do the same @TheRedDaemon and what do you prefer?
Contributor
There was a problem hiding this comment.
We agreed on using the relative import to mark the "main" header file, so this is something that should stay.
No idea on your question, though. I still use the integrated clang version of Visual Studio Code. Did you update your version recently to the newest? Maybe something was added regarding the imports?
gynt
force-pushed
the
reimpl/simple-functions-set-1
branch
3 times, most recently
from
August 24, 2026 19:03
0b76486 to
e6f6ab7
Compare
gynt
force-pushed
the
reimpl/simple-functions-set-1
branch
from
September 1, 2026 15:19
91680df to
d7291db
Compare
added 23 commits
September 2, 2026 11:00
added 14 commits
September 2, 2026 11:00
gynt
force-pushed
the
reimpl/simple-functions-set-1
branch
from
September 2, 2026 09:00
4de8840 to
4dbcfb4
Compare
added 15 commits
September 2, 2026 13:12
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.