fix/batches: validate shell probe paths - #1363
Open
cbrnrd wants to merge 1 commit into
Open
Conversation
Amp-Thread-ID: https://ampcode.com/threads/T-01a05d3c-cfaf-7540-9b4d-43c5e402c15b Co-authored-by: Amp <amp@ampcode.com>
cbrnrd
marked this pull request as ready for review
September 1, 2026 14:05
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
A batch step image controls the output of the
mktempshell probe. The CLI used that output in a Docker mount argument without validation, so invalid output could change the mount configuration. This was reported to us via HackerOne.Solution
Require the probe output to be one absolute POSIX path with safe characters. Validate the path again before building the mount, and use one helper to validate executor bind mounts. Add regression tests for mount argument injection.
Verification Evidence
go test ./internal/batches/...