support --help anywhere on command line #1195
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
burmudar
approved these changes
Nov 11, 2025
Member
Author
|
@marcleblanc2 if you are happy with this change, feel free to merge it in. |
marcleblanc2
force-pushed
the
k/alternative-help
branch
2 times, most recently
from
ffa458c to
8b1392f
Compare
Previously we special cased --help only for the first level of subcommands. However, this broke for example if you did "src snapshot upload --help". So instead we normalize our command line arguments so that if a user does "--help" we see "-help". We can then rely on go's stdlib flag parser to do the right thing w.r.t. sub commands/etc. Test Plan: ran with --help in a few different places and observed good behaviour.
marcleblanc2
force-pushed
the
k/alternative-help
branch
from
8b1392f to
030d182
Compare
Contributor
|
Whoops, accidentally merged main into this branch, fixed by reverting the merge commit and rebased your commit on top of main. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously we special cased --help only for the first level of subcommands. However, this broke for example if you did "src snapshot upload --help". So instead we normalize our command line arguments so that if a user does "--help" we see "-help". We can then rely on go's stdlib flag parser to do the right thing w.r.t. sub commands/etc.
Test Plan: ran with --help in a few different places and observed good behaviour.
Alternative to #1190