chore/dev: Retire dead CI config and modernize the Go build - #91
Closed
janhartman wants to merge 1 commit into
Closed
chore/dev: Retire dead CI config and modernize the Go build#91janhartman wants to merge 1 commit into
janhartman wants to merge 1 commit into
Conversation
Nothing has been verifying that this repository compiles: its CI config points at a service that no longer builds it. Replace that with a GitHub Actions workflow that builds, vets, and race-tests on Go 1.26, and — where the repository still predates Go modules — add go.mod/go.sum with a canonical module path and fix the code that no longer compiles on a modern toolchain.
janhartman
deleted the
go-modules-6ec3833b-bb95-4665-aea2-b19268cf924d
branch
September 1, 2026 12:47
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This repository carries CI configuration for a service that no longer builds it, so nothing has actually been verifying that it compiles. Most of these libraries also predate Go modules: without a
go.modthey cannot be built by any currently supported Go toolchain outside a GOPATH workspace, and they cannot be consumed as dependencies with reproducible versions.This change retires the dead configuration and replaces it with a GitHub Actions workflow that builds, vets, and race-tests against Go 1.26 on pull requests and on branch pushes. Where the repository is not yet on Go modules, it also adds a
go.modwith a canonical module path, resolves and pins its dependencies, and commitsgo.sum— updating the code where it no longer compiles on a modern toolchain. That means repointing legacysourcegraph.com/...vanity imports at their livegithub.com/...equivalents, removing canonical import-path comments that break module builds, replacingio/ioutilwith itsos/iosuccessors, and adding//go:buildconstraints alongside the older// +buildform. Build-status badges pointing at the retired CI services are dropped from the README.One deliberate reduction in scope: the new workflow runs on
ubuntu-latestonly. Where a repository previously ran a separate Windows job, that platform's tests are no longer executed in CI, though its platform-specific files are still vet-checked and cross-compiled.No new tests were written. Where a repository has no test suite, the workflow still builds and vets it. Any judgment calls — pinning an older dependency, replacing one that is no longer maintained, or skipping a test that needs an external binary — are recorded in
MODERNIZATION-NOTES.md.Created by Sourcegraph agentic batch change.